-
-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix serve errors on windows #3784
Conversation
const { stdout, stderr } = await runWatch(__dirname, ["serve", "-w", "--port", port]); | ||
|
||
expect(exitCode).toBe(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't test on the exit code for the serve
because we exit forcefully and the exit code is different on Linux/windows.
webpack-cli/test/utils/test-utils.js
Lines 31 to 37 in eaca5d2
const processKill = (process) => { | |
if (isWindows) { | |
exec("taskkill /pid " + process.pid + " /T /F"); | |
} else { | |
process.kill(); | |
} | |
}; |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3784 +/- ##
=======================================
Coverage 91.62% 91.62%
=======================================
Files 22 22
Lines 1624 1624
Branches 462 462
=======================================
Hits 1488 1488
Misses 136 136 Continue to review full report in Codecov by Sentry.
|
What kind of change does this PR introduce?
tests
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
no
Summary
Fix tests on master.
Follow up #3783
Does this PR introduce a breaking change?
No
Other information
No