Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete a comma for Node.js <= v7.x #1609

Merged
merged 1 commit into from
Dec 22, 2018

Conversation

3846masa
Copy link
Member

@3846masa 3846masa commented Dec 22, 2018

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

fixes #1607

Trailing commas in function syntax is not supported in Node.js <= v7.x
Remove comma.

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented Dec 22, 2018

Codecov Report

Merging #1609 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1609   +/-   ##
=======================================
  Coverage   74.25%   74.25%           
=======================================
  Files          10       10           
  Lines         672      672           
=======================================
  Hits          499      499           
  Misses        173      173
Impacted Files Coverage Δ
lib/Server.js 81.74% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9443239...3ea87a7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack-dev-server 3.1.12 seems broken
2 participants