Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecation message about setup now warning about v4 #1684

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No need

Motivation / Use-Case

We don't remove setup in v3, we should do this for v4

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #1684 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1684      +/-   ##
==========================================
+ Coverage   79.59%   79.63%   +0.03%     
==========================================
  Files           7        7              
  Lines         544      545       +1     
  Branches      165      166       +1     
==========================================
+ Hits          433      434       +1     
  Misses         84       84              
  Partials       27       27
Impacted Files Coverage Δ
lib/Server.js 80.15% <ø> (ø) ⬆️
lib/utils/createConfig.js 95.12% <0%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e5d12...575779c. Read the comment docs.

@alexander-akait alexander-akait merged commit 523a6ec into master Feb 25, 2019
@alexander-akait alexander-akait deleted the fix-deprecation-message branch February 25, 2019 09:34
Copy link

@MdGolam-Kibria MdGolam-Kibria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants