Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sockPath argv to options #1797

Closed
wants to merge 4 commits into from
Closed

feat: add sockPath argv to options #1797

wants to merge 4 commits into from

Conversation

zhangyuang
Copy link
Contributor

@zhangyuang zhangyuang commented Apr 13, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

test is already exist

Motivation / Use-Case

add options.sockPath = argv.sockPath

Breaking Changes

no

Additional Info

@codecov
Copy link

codecov bot commented Apr 13, 2019

Codecov Report

Merging #1797 into master will decrease coverage by 0.12%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1797      +/-   ##
==========================================
- Coverage   87.68%   87.56%   -0.13%     
==========================================
  Files           9        9              
  Lines         593      595       +2     
  Branches      177      178       +1     
==========================================
+ Hits          520      521       +1     
- Misses         61       62       +1     
  Partials       12       12
Impacted Files Coverage Δ
lib/utils/createConfig.js 94.62% <50%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59773d3...4372858. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's add test to CLI 👍

zhangyuang and others added 2 commits April 17, 2019 09:40
@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ zhangyuang
❌ yuang.zya


yuang.zya seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@zhangyuang zhangyuang closed this Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants