diff --git a/lib/Server.js b/lib/Server.js index 80eb1fe858..6f161258b1 100644 --- a/lib/Server.js +++ b/lib/Server.js @@ -228,11 +228,8 @@ class Server { }; const addHooks = (compiler) => { - const { compile, invalid, done } = compiler.hooks; - - compile.tap('webpack-dev-server', invalidPlugin); - invalid.tap('webpack-dev-server', invalidPlugin); - done.tap('webpack-dev-server', (stats) => { + compiler.hooks.invalid.tap('webpack-dev-server', invalidPlugin); + compiler.hooks.done.tap('webpack-dev-server', (stats) => { this.sendStats(this.webSocketConnections, this.getStats(stats)); this.stats = stats; }); diff --git a/test/e2e/__snapshots__/hot-and-live-reload.test.js.snap.webpack4 b/test/e2e/__snapshots__/hot-and-live-reload.test.js.snap.webpack4 index eb77be8e8b..67a715fb3b 100644 --- a/test/e2e/__snapshots__/hot-and-live-reload.test.js.snap.webpack4 +++ b/test/e2e/__snapshots__/hot-and-live-reload.test.js.snap.webpack4 @@ -18,7 +18,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -37,7 +36,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -56,7 +54,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -75,7 +72,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -94,7 +90,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -113,7 +108,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -131,7 +125,6 @@ Array [ "[HMR] Waiting for update signal from WDS...", "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -149,7 +142,6 @@ Array [ "[HMR] Waiting for update signal from WDS...", "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -167,7 +159,6 @@ Array [ "[HMR] Waiting for update signal from WDS...", "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -186,7 +177,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -205,7 +195,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -224,7 +213,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -243,7 +231,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -260,7 +247,6 @@ exports[`hot and live reload should work and refresh content using live reload ( Array [ "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App updated. Reloading...", "[webpack-dev-server] Live Reloading enabled.", ] @@ -272,7 +258,6 @@ exports[`hot and live reload should work and refresh content using live reload w Array [ "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App updated. Reloading...", "[webpack-dev-server] Live Reloading enabled.", ] @@ -284,7 +269,6 @@ exports[`hot and live reload should work and refresh content using live reload w Array [ "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App updated. Reloading...", "[webpack-dev-server] Live Reloading enabled.", ] diff --git a/test/e2e/__snapshots__/hot-and-live-reload.test.js.snap.webpack5 b/test/e2e/__snapshots__/hot-and-live-reload.test.js.snap.webpack5 index eb77be8e8b..67a715fb3b 100644 --- a/test/e2e/__snapshots__/hot-and-live-reload.test.js.snap.webpack5 +++ b/test/e2e/__snapshots__/hot-and-live-reload.test.js.snap.webpack5 @@ -18,7 +18,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -37,7 +36,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -56,7 +54,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -75,7 +72,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -94,7 +90,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -113,7 +108,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -131,7 +125,6 @@ Array [ "[HMR] Waiting for update signal from WDS...", "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -149,7 +142,6 @@ Array [ "[HMR] Waiting for update signal from WDS...", "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -167,7 +159,6 @@ Array [ "[HMR] Waiting for update signal from WDS...", "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -186,7 +177,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -205,7 +195,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -224,7 +213,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -243,7 +231,6 @@ Array [ "[webpack-dev-server] Hot Module Replacement enabled.", "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App hot update...", "[HMR] Checking for updates on the server...", "[HMR] Updated modules:", @@ -260,7 +247,6 @@ exports[`hot and live reload should work and refresh content using live reload ( Array [ "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App updated. Reloading...", "[webpack-dev-server] Live Reloading enabled.", ] @@ -272,7 +258,6 @@ exports[`hot and live reload should work and refresh content using live reload w Array [ "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App updated. Reloading...", "[webpack-dev-server] Live Reloading enabled.", ] @@ -284,7 +269,6 @@ exports[`hot and live reload should work and refresh content using live reload w Array [ "[webpack-dev-server] Live Reloading enabled.", "[webpack-dev-server] App updated. Recompiling...", - "[webpack-dev-server] App updated. Recompiling...", "[webpack-dev-server] App updated. Reloading...", "[webpack-dev-server] Live Reloading enabled.", ]