Reducing options for application servers #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| An application server MUST NOT use other content encodings for push messages. | ||
| In particular, content encodings that compress could result in leaking of push | ||
| message contents. The Content-Encoding header field therefore has exactly one | ||
| value, which is `aesgcm128`. |
There was a problem hiding this comment.
The "exactly one value" line linguistically confirms this, but since the beginning of this paragraph focuses on other content encodings rather than repeated content encodings, we disallow multiple rounds of aesgcm128 as well, right?
(HTTP encryption coding has an example that demonstrates this: https://tools.ietf.org/html/draft-thomson-http-encryption-01#section-5.3)
There was a problem hiding this comment.
Yeah, I'll clarify that point too. Thanks.
|
Thank you, Martin! This looks good to me. |
martinthomson
added a commit
that referenced
this pull request
Oct 19, 2015
Reducing options for application servers
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@beverloo was unhappy about the freedom we offered. This doesn't remove the header field separation, but it removes most of it.