Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Fix the issue of inactive infobox making sharing link unclickable #2

Merged
merged 1 commit into from
Feb 4, 2015
Merged

Fix the issue of inactive infobox making sharing link unclickable #2

merged 1 commit into from
Feb 4, 2015

Conversation

jiayliu
Copy link
Contributor

@jiayliu jiayliu commented Feb 4, 2015

The infobox is rendered as opacity:0 when inactive, covering the sharing link and making it unclickable.
Fixed by setting display:none when inactive.

@jiayliu
Copy link
Contributor Author

jiayliu commented Feb 4, 2015

@chuckhays

@chuckhays
Copy link
Contributor

LGTM.

jiayliu added a commit that referenced this pull request Feb 4, 2015
@jiayliu
Merge pull request #2 from jiayliu/infobox
a5b1af7 
Fix the issue of inactive infobox making sharing link unclickable
@jiayliu jiayliu merged commit a5b1af7 into webrtc:master Feb 4, 2015
@jiayliu jiayliu deleted the infobox branch February 4, 2015 17:14
@vanann123 vanann123 mentioned this pull request Nov 6, 2017
Closed
ankh-g added a commit that referenced this pull request Dec 3, 2018
@ankh-g
Two-way video is working.
788951e 
- In tab #1 join the room and then click to start sending video.
- In tab #2 join the room and then click to start sending video.

Video is received and decoded automatically, if the remote
peer sends it. However the local video is sent only on demand.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiayliu @chuckhays