Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reenable Firefox stable testing #1155

Merged
merged 1 commit into from
Mar 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/e2e-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
browser: [chrome]
version: [stable, beta, dev]
browser: [chrome, firefox]
version: [stable, beta]
include:
- browser: chrome
version: dev
- browser: firefox
version: nightly
steps:
Expand Down
22 changes: 0 additions & 22 deletions test/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,29 +11,7 @@
const os = require('os');
const puppeteerBrowsers = require('@puppeteer/browsers');

async function determineFirefoxVersion(version) {
const rawVersions = await fetch('https://product-details.mozilla.org/1.0/firefox_versions.json');
const versions = await rawVersions.json();
return versions.FIREFOX_NIGHTLY;
// TODO: support stable, beta, nightly, esr.
// This has issues with the assumptions browsers makes about download urls
// (or Firefox about directory structure and where it includes the platform)
// This base url coems close:
// 'https://archive.mozilla.org/pub/firefox/releases/' + buildId + '/' + platform + '/en-US/';
}

async function download(browser, version, cacheDir, platform) {
if (browser === 'firefox') {
// TODO: see above, resolve stable, beta, nightly, esr
const buildId = await determineFirefoxVersion(version);
await puppeteerBrowsers.install({
browser,
buildId,
cacheDir,
platform,
});
return buildId;
}
const buildId = await puppeteerBrowsers
.resolveBuildId(browser, platform, version);
await puppeteerBrowsers.install({
Expand Down