Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make canvas cursor style compatible across all browsers #4727

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Jan 6, 2025

Description

Safari does not change the cursor based on
-webkit-user-select: none;

We need to explicitly set cursor

ref #1818

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov requested review from kof and TrySound January 6, 2025 20:44
@istarkov istarkov changed the title feat: Make cursor style compatible across all browsers feat: Make canvas cursor style compatible across all browsers Jan 6, 2025
@istarkov istarkov merged commit cbbf694 into main Jan 7, 2025
17 checks passed
@istarkov istarkov deleted the cursor branch January 7, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants