Fix false positive in AvoidSinglePipeOperator (fsprojects#640)

We already had a test for this scenario, but with one parameter. This adds a testcase with two parameters.
webwarrior-ws · Dec 20, 2023 · 96c4e36 · 96c4e36
1 parent 44dbf24
commit 96c4e36
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 15 deletions.
diff --git a/src/FSharpLint.Core/Rules/Conventions/AvoidSinglePipeOperator.fs b/src/FSharpLint.Core/Rules/Conventions/AvoidSinglePipeOperator.fs
@@ -28,21 +28,8 @@ let runner (args: AstNodeRuleParams) =
                     | SynExpr.Ident ident ->
                         if ident.idText = "op_PipeRight" then
                             match argExpr with
-                            | SynExpr.App(_exprAtomicFlag, _isInfix, funcExpr, _argExpr, range) ->
-                                match funcExpr with
-                                | SynExpr.App(_exprAtomicFlag, _isInfix, funcExpr, _argExpr, range) ->
-                                    match funcExpr with
-                                    | SynExpr.Ident ident ->
-                                        if ident.idText = "op_PipeRight" then
-                                            Array.empty
-                                        else
-                                            errors range
-                                    | _ ->
-                                        errors range
-                                | SynExpr.Ident _ident ->
-                                    Array.empty                                
-                                | _ ->
-                                    errors range
+                            | SynExpr.App(_exprAtomicFlag, _isInfix, _funcExpr, _argExpr, _range) ->
+                                Array.empty 
                             | _ ->
                                 errors range
                         else

diff --git a/tests/FSharpLint.Core.Tests/Rules/Conventions/AvoidSinglePipeOperator.fs b/tests/FSharpLint.Core.Tests/Rules/Conventions/AvoidSinglePipeOperator.fs
@@ -84,3 +84,13 @@ let someFunc someParam =
 """
 
         Assert.IsFalse this.ErrorsExist
+
+
+    [<Test>]
+    member this.``Use pipe operator once to avoid parenthesis on expression with function application``() =
+        this.Parse """
+let someFunc someParam =
+    someOtherFunc1 someParam someParam2 |> someOtherFunc3
+"""
+
+        Assert.IsFalse this.ErrorsExist