Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support image and file messages #82

Merged
merged 13 commits into from
Jul 28, 2021
Merged

Support image and file messages #82

merged 13 commits into from
Jul 28, 2021

Conversation

lprintf
Copy link
Contributor

@lprintf lprintf commented Jul 19, 2021

support receive image in both padlocal and web protocol.

@lprintf lprintf mentioned this pull request Jul 19, 2021
Closed
@lprintf lprintf changed the title Support image message (receive) Support image message Jul 20, 2021
@lprintf lprintf mentioned this pull request Jul 21, 2021
Merged
@huan
Copy link
Member

huan commented Jul 22, 2021

Please resolve the conflicts.

@lprintf lprintf force-pushed the support-image-message branch from e066544 to 88b1d64 Compare July 23, 2021 06:06
@lprintf
Copy link
Contributor Author

lprintf commented Jul 24, 2021 •
edited
Loading

  • send Images to users (excloud gif show)
  • send Images to rooms (excloud gif show)
  • send files to users
  • send files to rooms
  • receive Images from users
  • receive Images from rooms
  • receive files from users
  • receive files from rooms

@lprintf lprintf mentioned this pull request Jul 25, 2021
Open
@lprintf lprintf changed the title Support image message Support image and file messages Jul 27, 2021
@lprintf lprintf requested a review from huan July 27, 2021 06:28
huan
huan requested changes Jul 27, 2021
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great improvements for our matrix project!

Before we can continue reviewing this PR, please:

  1. Resolve the conflicts in your PR, or we can not merge it at all
  2. For this PR is not minor, we need a more design explanation to description what this PR did in detail, so that we can review it in the future in case of there's any bugs.

Please create an issue to describe what you have done in the PR and link then together, I'd like to suggest that the related matrix SDK documentation link should be included.

林宇靖 added 2 commits July 27, 2021 02:55
Merge branch 'wechaty-master' into support-image-message
a4782d6 
Conflicts:
package.json
src/appservice-manager.ts
0.8.32
abcdbc9
@lprintf
Copy link
Contributor Author

lprintf commented Jul 27, 2021

merge main to this branch and create an issue #86 .

@lprintf lprintf requested a review from huan July 27, 2021 07:27
lprintf
lprintf commented Jul 27, 2021
View reviewed changes
Copy link
Contributor Author

@lprintf lprintf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#86

@huan
Copy link
Member

huan commented Jul 27, 2021

It's great to see the conflict has been resolved, and you have created an issue to describe this PR! (it would be better if it can be in more detail)

I'd like to merge this PR after it gets approval from your work-mate @zrn-fight, please ask her and invite her to review and approve this PR so that we will be able to merge it after she feels everything is ok with it.

@yswtrue Please feel free to comment/request changes / approve this PR as you like.

Thank you very much!

@lprintf lprintf requested review from yswtrue and zrn-fight July 27, 2021 14:01
huan
huan approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @yswtrue, and @zrn-fight for the approvements!

@huan huan merged commit 05cf616 into wechaty:master Jul 28, 2021
@lprintf lprintf mentioned this pull request Aug 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zrn-fight zrn-fight zrn-fight approved these changes

@huan huan huan approved these changes

@yswtrue yswtrue yswtrue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lprintf @huan @yswtrue @zrn-fight