Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to Support WECHATY_PUPPET_PUPPETEER_ENDPOINT Environment Variables #143

Merged
merged 2 commits into from
Jul 19, 2021

Conversation

lprintf
Copy link
Contributor

@lprintf lprintf commented Jul 19, 2021

allow to config chrome/chromium path by setting the environment variable named WECHATY_PUPPET_PUPPETEER_ENDPOINT.
It is for solve the problem failed stated PuppetWeChatBridge in some environment.
see: wechaty/matrix-appservice#78 (comment)

林宇靖 added 2 commits July 18, 2021 23:33
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you very much for adding endpoint support for wechaty-puppet-wechat module!

@huan
Copy link
Member

huan commented Jul 19, 2021

Could you please send another PR to add this new environment variable WECHATY_PUPPET_PUPPETEER_ENDPOINT config doc to README, so that other developers can be able to learn how to use it?

@lprintf
Copy link
Contributor Author

lprintf commented Jul 19, 2021

Could you please send another PR to add this new environment variable WECHATY_PUPPET_PUPPETEER_ENDPOINT config doc to README, so that other developers can be able to learn how to use it?

OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants