Track variable usage in bool to int casts

Fixes vimeo#4956
weirdan · Mar 8, 2021 · 24f2212 · 24f2212
1 parent 3c66b75
commit 24f2212
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/CastAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/CastAnalyzer.php
@@ -71,10 +71,18 @@ public static function analyze(
 
                 if (count($maybe) === 1 && current($maybe) instanceof Type\Atomic\TBool) {
                     $as_int = false;
-                    $statements_analyzer->node_data->setType($stmt, new Type\Union([
+                    $type = new Type\Union([
                         new Type\Atomic\TLiteralInt(0),
                         new Type\Atomic\TLiteralInt(1),
-                    ]));
+                    ]);
+
+                    if ($statements_analyzer->data_flow_graph
+                        && $statements_analyzer->data_flow_graph instanceof \Psalm\Internal\Codebase\VariableUseGraph
+                    ) {
+                        $type->parent_nodes = $maybe_type->parent_nodes;
+                    }
+
+                    $statements_analyzer->node_data->setType($stmt, $type);
                 }
             }
 

diff --git a/tests/UnusedVariableTest.php b/tests/UnusedVariableTest.php
@@ -2316,6 +2316,18 @@ function createFailingFunction(RuntimeException $exception): Closure
                         };
                     }
                 ',
+            ],
+            'usedInIntCastInAssignment' => [
+                '<?php
+                    /** @return mixed */
+                    function f() {
+                        $a = random_int(0, 10) >= 5 ? true : false;
+
+                        $b = (int) $a;
+
+                        return $b;
+                    }
+                '
             ]
         ];
     }