Introduce annotation for changing bean discovery mode in synthetic archive #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkouba
reviewed
Oct 31, 2023
junit5/src/main/java/org/jboss/weld/junit5/auto/SetSyntheticArchiveDiscoveryMode.java
Outdated
Show resolved
Hide resolved
mkouba
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158
Related JIRA - https://issues.redhat.com/browse/WELD-2766
We could also choose to drop the value on the annotation (always setting
allasnoneis an error anyway). However, that would then make a mess of it in case there is a hierarchy of test classes with multiple declarations of this annotation.Another option would be to add this as a param to an existing annotation such as
@EnableAutoWeldbut that one is optional in that you can use@ExtendWith(WeldJunit5AutoExtension.class)instead.