Update link resolver #11190
Draft
Update link resolver #11190
+118
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # content/webapp/pages/series/[seriesId].tsx
|
Size Change: +95 B (+0.01%) Total Size: 983 kB
ℹ️ View Unchanged
|
rcantin-w
reviewed
Sep 18, 2024
| if ( | ||
| type === 'exhibition-guides' || | ||
| type === 'exhibition-texts' || | ||
| type === 'exhibition-highlight-tours' | ||
| ) | ||
| return `/guides/exhibitions/${id}`; | ||
| return `/guides/exhibitions/${uid}`; |
There was a problem hiding this comment.
This is kind of unrelated to this ticket, but am I correct in thinking this could potentially link to a 404 since it only uses one of the guides' id?
rcantin-w
reviewed
Sep 18, 2024
| @@ -22,8 +22,10 @@ export const getServerSideProps = async context => { | |||
|
|
|||
| const visualStoryDocument = visualStoriesQuery.results.find(result => { | |||
| return ( | |||
| // TODO once redirects are in place we should only compare with uid | |||
There was a problem hiding this comment.
Can we link to a ticket (is there one)?
rcantin-w
reviewed
Sep 18, 2024
| @@ -22,8 +22,10 @@ export const getServerSideProps = async context => { | |||
|
|
|||
| const visualStoryDocument = visualStoriesQuery.results.find(result => { | |||
| return ( | |||
| // TODO once redirects are in place we should only compare with uid | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
For #11074
How to test
How can we measure success?
Human readable uid is present in the url of a page rather than the id of the document
Have we considered potential risks?