From c5db134544b8234e89aa01b9c13f35571040b78e Mon Sep 17 00:00:00 2001 From: Wes McKinney Date: Mon, 8 Feb 2016 17:37:05 -0800 Subject: [PATCH] PARQUET-513: Fail build if valgrind finds error during ctest, fix a core dump Also adds an option to use ccache with a custom gcc toolchain. Fixes an improper memory access stemming from a unit test that had a wrong parameter. Author: Wes McKinney Closes #42 from wesm/PARQUET-513 and squashes the following commits: 43df9e7 [Wes McKinney] Fix core dump from unit test bug b46c617 [Wes McKinney] Fail build if valgrind finds error during ctest Change-Id: I4e04fee7db2ed7a0af21ab25b9d7566314d07ac4 --- cpp/src/parquet/schema/schema-converter-test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/src/parquet/schema/schema-converter-test.cc b/cpp/src/parquet/schema/schema-converter-test.cc index a5e1df777a311..f2dadf26026b8 100644 --- a/cpp/src/parquet/schema/schema-converter-test.cc +++ b/cpp/src/parquet/schema/schema-converter-test.cc @@ -125,7 +125,7 @@ TEST_F(TestSchemaConverter, NotEnoughChildren) { SchemaElement elt; std::vector elements; elements.push_back(NewGroup(name_, FieldRepetitionType::REPEATED, 2)); - ASSERT_THROW(Convert(&elements[0], 2), ParquetException); + ASSERT_THROW(Convert(&elements[0], 1), ParquetException); } // ----------------------------------------------------------------------