Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make websocket can be used in service worker #2579

Closed
wants to merge 1 commit into from

Conversation

zouhangwithsweet
Copy link

@zouhangwithsweet zouhangwithsweet commented Aug 3, 2024

import() is disallowed on ServiceWorkerGlobalScope by the HTML specification. See w3c/ServiceWorker#1356.


PR-Codex overview

The focus of this PR is to update the WebSocket import in webSocket.ts file to use isows.

Detailed summary

  • Updated WebSocket import to use isows
  • Removed dynamic import for WebSocket

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Aug 3, 2024

⚠️ No Changeset found

Latest commit: 3c9912a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 3, 2024

@zouhangwithsweet is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@jxom
Copy link
Member

jxom commented Aug 3, 2024

This will break some serverless environments 😅

@zouhangwithsweet
Copy link
Author

This will break some serverless environments 😅

So is there a better solution here? For now, I just add a patch in my repo.

@jxom
Copy link
Member

jxom commented Aug 8, 2024

Will think of a better solution, but closing for now.

@jxom jxom closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants