remove show_update_window functionality

dependabot is trying to update pulldown-cmark, but it won't work because the API has changed. The update window is not enabled by default and I don't think anyone uses it anyway, so let's just remove it and have less code to compile and maintain. closes: #4964
wez · Feb 5, 2024 · 39d2b6c · 39d2b6c
1 parent 11a3133
commit 39d2b6c
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 588 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/config/src/config.rs b/config/src/config.rs
@@ -687,7 +687,10 @@ pub struct Config {
 
     #[dynamic(default = "default_check_for_updates")]
     pub check_for_updates: bool,
-    #[dynamic(default)]
+    #[dynamic(
+        default,
+        deprecated = "this option no longer does anything and will be removed in a future release"
+    )]
     pub show_update_window: bool,
 
     #[dynamic(default = "default_update_interval")]

diff --git a/docs/changelog.md b/docs/changelog.md
@@ -25,6 +25,9 @@ As features stabilize some brief notes about them will accumulate here.
 * Wayland: currently being reimplemented, it maybe more unstable than usual.
   Please file GH issues for any problems you see.
   Many thanks to @tzx! #4777
+* [show_update_window](config/lua/config/show_update_window.md) has been
+  deprecated; it no longer has any effect and will be removed in a future
+  release.
 #### New
 #### Fixed
 * Race condition when very quickly adjusting font scale. Thanks to @jknockel!

diff --git a/docs/config/lua/config/show_update_window.md b/docs/config/lua/config/show_update_window.md
@@ -14,3 +14,7 @@ the automatic update checks.
 ```lua
 config.show_update_window = false
 ```
+
+{{since('nightly')}}
+
+This option no longer has any effect and will be removed in a future release.
diff --git a/wezterm-gui/Cargo.toml b/wezterm-gui/Cargo.toml
@@ -70,7 +70,6 @@ ordered-float = "4.1"
 parking_lot = "0.12"
 portable-pty = { path = "../pty", features = ["serde_support"]}
 promise = { path = "../promise" }
-pulldown-cmark = "0.9"
 rangeset = { path = "../rangeset" }
 ratelim= { path = "../ratelim" }
 rayon = "1.7"

diff --git a/wezterm-gui/src/main.rs b/wezterm-gui/src/main.rs
@@ -39,7 +39,6 @@ mod download;
 mod frontend;
 mod glyphcache;
 mod inputmap;
-mod markdown;
 mod overlay;
 mod quad;
 mod renderstate;

diff --git a/wezterm-gui/src/markdown.rs b/wezterm-gui/src/markdown.rs