add a method to get a Uint8Array to Body #1732
Labels
Comments
bakkot
added
addition/proposal
|
FWIW, WebKit is okay with adding this. cc @valenting @ricea |
|
Sounds good to me, but I'd like @saschanaz 's opinion as well. |
|
Sounds okay to me. |
annevk
added
needs concrete proposal
|
Chromium supports. |
This was referenced May 4, 2024
This was referenced May 13, 2024
annevk
pushed a commit
that referenced
this issue
May 14, 2024
Returns a Uint8Array as opposed to requiring users to get an ArrayBuffer and wrap it. Tests: web-platform-tests/wpt#46198. Fixes #1732.
annevk
removed
the
needs concrete proposal
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
Oct 3, 2024
This CL adds a bytes() method to get Uint8Array to body, instead of requiring users to get an ArrayBuffer with arrayBuffer() and wrap it. whatwg/fetch#1732 https://chromestatus.com/feature/5239268180754432 Bug: 340206277 Change-Id: I48a96970450592bcbae7d0a8b79f68b9bd0b556b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5895865 Reviewed-by: Rick Byers <rbyers@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Commit-Queue: Perry <perryuwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#1363676}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What problem are you trying to solve?
Body has an
.arrayBuffer()method, but that's almost never what you actually want, since you can't read out of a buffer directly - you need a view. Uint8Array is the canonical "sequence of byte values" view.What solutions exist today?
new Uint8Array(await body.arrayBuffer())How would you solve it?
Add a
.bytes()method which gives a newUint8Array.Anything else?
Some brief discussion here.
PushMessageData and Blob (which live elsewhere) would need this too, since they just copied Body.
(Also, watch out for #1675 while specifying.)
The text was updated successfully, but these errors were encountered: