Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noopener with window.open #2474

Closed
zcorpan opened this issue Mar 27, 2017 · 2 comments
Closed

noopener with window.open #2474

zcorpan opened this issue Mar 27, 2017 · 2 comments

Comments

@zcorpan
Copy link
Member

zcorpan commented Mar 27, 2017

https://html.spec.whatwg.org/#apis-for-creating-and-navigating-browsing-contexts-by-name

If the result of splitting features on commas contains the token "noopener", then disown target browsing context's opener and return null.

Is this right? This wouldn't allow for spaces around the comma, or uppercase NOOPENER, for example. It seems more robust to use the same tokenizer as the legacy features and check the tokenized name if it's "noopener".

https://drafts.csswg.org/cssom-view/#the-features-argument-to-the-open()-method

cc @mikewest @lyzadanger
@zcorpan
Copy link
Member Author

zcorpan commented Mar 27, 2017

http://software.hixie.ch/utilities/js/live-dom-viewer/saved/4984

@lyzadanger
Copy link

It seems more robust to use the same tokenizer as the legacy features and check the tokenized name if it's "noopener".

Yes, I agree @zcorpan .

zcorpan added a commit that referenced this issue Mar 27, 2017
@zcorpan
Specify the tokenizer for window.open's features argument
5269fd9 
This was specified in CSSOM View but the "noopener" feature did
not use the same tokenizer as the legacy features. Fixes #2474.

Also specify the aliases screenx, screeny, innerwidth, innerheight
for left, top, width, and height, respectively. Part of #2464.
Closes w3c/csswg-drafts#1128.
@zcorpan zcorpan mentioned this issue Mar 27, 2017
Merged
zcorpan added a commit that referenced this issue Apr 5, 2017
@zcorpan
Specify the tokenizer for window.open's features argument
79cc5a0 
This was specified in CSSOM View but the "noopener" feature did
not use the same tokenizer as the legacy features. Fixes #2474.

Also specify the aliases screenx, screeny, innerwidth, innerheight
for left, top, width, and height, respectively. Part of #2464.
Closes w3c/csswg-drafts#1128.

The tokenizer specified here closely follows Chromium and WebKit.
Difference from Chromium: U+0000 is not a separator.
Difference from WebKit and Chromium: U+000C is a separator.
zcorpan added a commit that referenced this issue Apr 6, 2017
@zcorpan
Specify the tokenizer for window.open's features argument
b649435 
This was specified in CSSOM View but the "noopener" feature did
not use the same tokenizer as the legacy features. Fixes #2474.

Also specify the aliases screenx, screeny, innerwidth, innerheight
for left, top, width, and height, respectively. Part of #2464.
Closes w3c/csswg-drafts#1128.

The tokenizer specified here closely follows Edge.
Chromium and WebKit are also very similar to Edge.
Difference from Edge: U+0000 does not end the string.
Difference from Chromium: U+0000 is not a separator.
Difference from WebKit/Chromium/Edge: U+000C is a separator.

For the input `width toolbar=450, height=450`,
Edge tokenizes like `width, toolbar=450, height=450` while
WebKit/Chromium like `width=450, height=450`.
The Edge behavior seems better.

Tests:
web-platform-tests/wpt#5306
web-platform-tests/wpt#5390
inikulin pushed a commit to HTMLParseErrorWG/html that referenced this issue May 9, 2017
@zcorpan @inikulin
Specify the tokenizer for window.open's features argument
c70facd 
This was specified in CSSOM View but the "noopener" feature did
not use the same tokenizer as the legacy features. Fixes whatwg#2474.

Also specify the aliases screenx, screeny, innerwidth, innerheight
for left, top, width, and height, respectively. Part of whatwg#2464.
Closes w3c/csswg-drafts#1128.

The tokenizer specified here closely follows Edge.
Chromium and WebKit are also very similar to Edge.
Difference from Edge: U+0000 does not end the string.
Difference from Chromium: U+0000 is not a separator.
Difference from WebKit/Chromium/Edge: U+000C is a separator.

For the input `width toolbar=450, height=450`,
Edge tokenizes like `width, toolbar=450, height=450` while
WebKit/Chromium like `width=450, height=450`.
The Edge behavior seems better.

Tests:
web-platform-tests/wpt#5306
web-platform-tests/wpt#5390
inikulin pushed a commit to HTMLParseErrorWG/html that referenced this issue May 9, 2017
@zcorpan @inikulin
Specify the tokenizer for window.open's features argument
c23de2f 
This was specified in CSSOM View but the "noopener" feature did
not use the same tokenizer as the legacy features. Fixes whatwg#2474.

Also specify the aliases screenx, screeny, innerwidth, innerheight
for left, top, width, and height, respectively. Part of whatwg#2464.
Closes w3c/csswg-drafts#1128.

The tokenizer specified here closely follows Edge.
Chromium and WebKit are also very similar to Edge.
Difference from Edge: U+0000 does not end the string.
Difference from Chromium: U+0000 is not a separator.
Difference from WebKit/Chromium/Edge: U+000C is a separator.

For the input `width toolbar=450, height=450`,
Edge tokenizes like `width, toolbar=450, height=450` while
WebKit/Chromium like `width=450, height=450`.
The Edge behavior seems better.

Tests:
web-platform-tests/wpt#5306
web-platform-tests/wpt#5390
@annevk annevk mentioned this issue Oct 9, 2017
Closed
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@zcorpan
Specify the tokenizer for window.open's features argument
5616fb9 
This was specified in CSSOM View but the "noopener" feature did
not use the same tokenizer as the legacy features. Fixes whatwg#2474.

Also specify the aliases screenx, screeny, innerwidth, innerheight
for left, top, width, and height, respectively. Part of whatwg#2464.
Closes w3c/csswg-drafts#1128.

The tokenizer specified here closely follows Edge.
Chromium and WebKit are also very similar to Edge.
Difference from Edge: U+0000 does not end the string.
Difference from Chromium: U+0000 is not a separator.
Difference from WebKit/Chromium/Edge: U+000C is a separator.

For the input `width toolbar=450, height=450`,
Edge tokenizes like `width, toolbar=450, height=450` while
WebKit/Chromium like `width=450, height=450`.
The Edge behavior seems better.

Tests:
web-platform-tests/wpt#5306
web-platform-tests/wpt#5390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zcorpan @lyzadanger