Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define BarProp lifetime better #2579

Closed
annevk opened this issue Apr 24, 2017 · 1 comment
Closed

Define BarProp lifetime better #2579

annevk opened this issue Apr 24, 2017 · 1 comment
Labels
interop Implementations are not interoperable with each other topic: frames/navigables/browsing contexts

Comments

@annevk
Copy link
Member

annevk commented Apr 24, 2017

In particular we cannot tie it to browsing contexts, as those can be discarded.

const frame = self[0]
alert(frame.menubar)
frame.frameElement.remove()
alert(frame.menubar)

Firefox: obj, obj
Safari TP: obj, undefined
Chrome: obj, obj
Edge: obj, exception ("Object expected")

In Firefox and Chrome visible will return false for the case lacking a browsing context. That's probably what we should go with.

@annevk annevk added the interop Implementations are not interoperable with each other label Apr 24, 2017
annevk added a commit to web-platform-tests/wpt that referenced this issue Mar 13, 2019
@annevk
Copy link
Member Author

annevk commented Mar 13, 2019

Per https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/frame/bar_prop.cc and https://github.com/WebKit/webkit/blob/master/Source/WebCore/page/BarProp.cpp I guess there are scenarios where the individual values can differ, at least for some. Specifying that in more detail is probably best tracked separately?

annevk added a commit that referenced this issue Mar 13, 2019
Also describe what happens when the browsing context is discarded.

Tests: web-platform-tests/wpt#15815.

Fixes #2579.
annevk added a commit that referenced this issue Mar 14, 2019
Also describe what happens when the browsing context is discarded.

Tests: web-platform-tests/wpt#15815.

Follow-up: #4431.

Fixes #2579.
domenic pushed a commit to web-platform-tests/wpt that referenced this issue Mar 15, 2019
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Apr 1, 2019
Automatic update from web-platform-tests
HTML: BarProp objects

For whatwg/html#2579.
--

wpt-commits: d256b6d90b9ae7ed23a2460d27e5bcd47a0ac6a9
wpt-pr: 15815
mykmelez pushed a commit to mykmelez/gecko that referenced this issue Apr 2, 2019
Automatic update from web-platform-tests
HTML: BarProp objects

For whatwg/html#2579.
--

wpt-commits: d256b6d90b9ae7ed23a2460d27e5bcd47a0ac6a9
wpt-pr: 15815
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this issue Jul 23, 2019
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 4, 2019
Automatic update from web-platform-tests
HTML: BarProp objects

For whatwg/html#2579.
--

wpt-commits: d256b6d90b9ae7ed23a2460d27e5bcd47a0ac6a9
wpt-pr: 15815

UltraBlame original commit: f1856d96d0583f6b926462f5183a38d934be8eb8
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 4, 2019
Automatic update from web-platform-tests
HTML: BarProp objects

For whatwg/html#2579.
--

wpt-commits: d256b6d90b9ae7ed23a2460d27e5bcd47a0ac6a9
wpt-pr: 15815

UltraBlame original commit: f1856d96d0583f6b926462f5183a38d934be8eb8
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 4, 2019
Automatic update from web-platform-tests
HTML: BarProp objects

For whatwg/html#2579.
--

wpt-commits: d256b6d90b9ae7ed23a2460d27e5bcd47a0ac6a9
wpt-pr: 15815

UltraBlame original commit: f1856d96d0583f6b926462f5183a38d934be8eb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interop Implementations are not interoperable with each other topic: frames/navigables/browsing contexts
Development

No branches or pull requests

2 participants