Add a low latency mode for 2D/3D Canvas contexts #4087

yell0wd0g · 2018-10-11T23:12:13Z

@junov filed #2659 for OffscreenCanvas. This is a sister issue for on-screen canvas (2d/3d), and is needed as a companion for Chromium development happening in http://crbug.com/788439 (mostly for ChromeOS since there we control the OS Compositor).

The original proposal from @junov stays the same with s/singleBuffered/lowLatency/, i.e. add a

partial dictionary CanvasContextCreationAttributes {
  boolean lowLatency = false;
}

+cc @fserb, @wffurr, @beaufortfrancois

The text was updated successfully, but these errors were encountered:

annevk · 2018-10-12T07:51:14Z

@whatwg/canvas

yell0wd0g · 2018-10-16T16:13:07Z

For future reference, one of my concerns was how to communicate back to the app if/when lowLatency is supported but @kenrussell brought to my attention that getContextAttributes() returns the actual context parameters, and this can be used. I haven't found a similar readback mechanism on 2D canvas contexts though.

annevk · 2018-10-16T17:19:09Z

That's #2563, but hasn't been touched in a while.

domenic · 2018-11-14T01:08:23Z

Is anyone considering working on a pull request for this? And/or for #2563?

wffurr · 2018-11-23T16:10:32Z

There's an origin trial for this in Chrome 71: https://www.chromestatus.com/feature/6360971442388992

domenic · 2018-11-23T16:57:02Z

I sure hope nobody is considering shipping it without a spec.

Developers of stylus-based drawing applications (e.g. Google Keep) have found this hint to be critical in order to be competitive with native applications. It has been prototyped in Chromium and yields significant latency improvements there. Partial fix for whatwg#4087.

Developers of stylus-based drawing applications (e.g. Google Keep) have found this hint to be critical in order to be competitive with native applications. It has been prototyped in Chromium and yields significant latency improvements there. This is the WebGL analogue of whatwg/html#4234 and partially addresses whatwg/html#4087 .

domenic · 2018-12-18T21:58:56Z

Are other implementers interested in this? There's a spec up at #4234.

Developers of stylus-based drawing applications (e.g. Google Keep) have found this hint to be critical in order to be competitive with native applications. It has been prototyped in Chromium and yields significant latency improvements there. This is the WebGL analogue of whatwg/html#4234 and partially addresses whatwg/html#4087 .

yell0wd0g · 2018-12-19T20:30:55Z

@jan-ivar from FF to say how they like this Spec proposal/ forward to some other interested FF devs

jan-ivar · 2018-12-19T20:50:19Z

I'll defer to @annevk here.

kenrussell · 2018-12-22T00:09:37Z

@jdashg from Mozilla has given good feedback on this proposal in the WebGL working group.

domenic · 2018-12-22T00:11:48Z

Thanks, is there any public (e.g. minuted) sign of implementation interest we can link to?

annevk · 2019-01-03T10:42:51Z

@jrmuizel might also be able to comment on behalf of Mozilla.

Developers of stylus-based drawing applications (e.g. Google Keep) have found this hint to be critical in order to be competitive with native applications. It has been prototyped in Chromium and yields significant latency improvements there. Partial fix for whatwg#4087.

Developers of stylus-based drawing applications (e.g., Google Keep) have found this hint to be critical in order to be competitive with native applications. It has been prototyped in Chromium and yields significant latency improvements there. Tests: will be added as part of https://bugs.chromium.org/p/chromium/issues/detail?id=788439. Supersedes #4234. Partial fix for #4087. Co-authored-by: Miguel Casas-Sanchez <mcasas@chromium.org>

This CL renames s/lowLatency/desynchronized/ on web-exposed parts (s/low_latency/desynchronized/ internally) following [1,2] PRs (issue [3]), and extends wpt getContextAttributes.html. [1] whatwg/html#4360 [2] KhronosGroup/WebGL#2753 [3] whatwg/html#4087 Bug: 944199 Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f

This CL renames s/lowLatency/desynchronized/ on web-exposed parts (s/low_latency/desynchronized/ internally) following [1,2] PRs (issue [3]), and extends wpt getContextAttributes.html. [1] whatwg/html#4360 [2] KhronosGroup/WebGL#2753 [3] whatwg/html#4087 Bug: 944199 Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#643323}

…t, a=testonly Automatic update from web-platform-tests Extend canvas getContextAttributes WPTest This CL extend the WPTest for Canvas getContextAttributes to include the |desynchronized|. This CL covers the flag WPT test extension mentioned in whatwg/html#4360 (which addressed whatwg/html#4087). Bug: 944199, 945835 Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#644332} -- wpt-commits: c3f8e5c0bb15e7d7f57dbe60f6869caa0c4ad2e7 wpt-pr: 16084

This CL renames s/lowLatency/desynchronized/ on web-exposed parts (s/low_latency/desynchronized/ internally) following [1,2] PRs (issue [3]), and extends wpt getContextAttributes.html. [1] whatwg/html#4360 [2] KhronosGroup/WebGL#2753 [3] whatwg/html#4087 Bug: 944199 Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#643323}

This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905. Reason for revert: Suspect cause of failure in webkit_layout_tests: * external/wpt/2dcontext/context-attributes/getContextAttributes.html https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391 Original change's description: > WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ > > This CL renames s/lowLatency/desynchronized/ on web-exposed parts > (s/low_latency/desynchronized/ internally) following [1,2] PRs > (issue [3]), and extends wpt getContextAttributes.html. > > [1] whatwg/html#4360 > [2] KhronosGroup/WebGL#2753 > [3] whatwg/html#4087 > > Bug: 944199 > Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#643323} TBR=mcasas@chromium.org,foolip@chromium.org Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473 Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#643430}

This CL extend the WPTest for Canvas getContextAttributes to include the |desynchronized|. This CL covers the flag WPT test extension mentioned in whatwg/html#4360 (which addressed whatwg/html#4087). Bug: 944199, 945835 Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#644332}

smfr · 2019-08-23T22:56:40Z

I'd like the spec to say a bit more about how "desynchronized" affects event handling, if at all. Presumably the page still has to run JS to handle pointer events and call canvas API; does that part follow the normal HTML event loop rules? If so, isn't canvas update rate still limited by how responsive the event loop is?

annevk · 2019-08-26T09:26:32Z

This should have been closed by #4360. Filed #4865 for @smfr's comment.

…y/desynchronized/, a=testonly Automatic update from web-platform-tests WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ This CL renames s/lowLatency/desynchronized/ on web-exposed parts (s/low_latency/desynchronized/ internally) following [1,2] PRs (issue [3]), and extends wpt getContextAttributes.html. [1] whatwg/html#4360 [2] KhronosGroup/WebGL#2753 [3] whatwg/html#4087 Bug: 944199 Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 Reviewed-by: Philip Jägenstedt <foolipchromium.org> Commit-Queue: Miguel Casas <mcasaschromium.org> Cr-Commit-Position: refs/heads/master{#643323} -- wpt-commits: 02e61522099b874a0075d058f89b9f549563c6dc wpt-pr: 15982 UltraBlame original commit: e67259837e8158c2f585ec79fdd5355eacadcc8b

…owLatency/desynchronized/", a=testonly Automatic update from web-platform-tests Revert "WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/" This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905. Reason for revert: Suspect cause of failure in webkit_layout_tests: * external/wpt/2dcontext/context-attributes/getContextAttributes.html https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391 Original change's description: > WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ > > This CL renames s/lowLatency/desynchronized/ on web-exposed parts > (s/low_latency/desynchronized/ internally) following [1,2] PRs > (issue [3]), and extends wpt getContextAttributes.html. > > [1] whatwg/html#4360 > [2] KhronosGroup/WebGL#2753 > [3] whatwg/html#4087 > > Bug: 944199 > Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 > Reviewed-by: Philip Jägenstedt <foolipchromium.org> > Commit-Queue: Miguel Casas <mcasaschromium.org> > Cr-Commit-Position: refs/heads/master{#643323} TBR=mcasaschromium.org,foolipchromium.org Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473 Reviewed-by: Fabrice de Gans-Riberi <fdeganschromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdeganschromium.org> Cr-Commit-Position: refs/heads/master{#643430} -- wpt-commits: d62bee5a53daade043c4704dc77379bdd2db0ea8 wpt-pr: 16029 UltraBlame original commit: 0af953b7bc949a695ba962e2eeda584175bb602b

…t, a=testonly Automatic update from web-platform-tests Extend canvas getContextAttributes WPTest This CL extend the WPTest for Canvas getContextAttributes to include the |desynchronized|. This CL covers the flag WPT test extension mentioned in whatwg/html#4360 (which addressed whatwg/html#4087). Bug: 944199, 945835 Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491 Reviewed-by: Fernando Serboncini <fserbchromium.org> Commit-Queue: Miguel Casas <mcasaschromium.org> Cr-Commit-Position: refs/heads/master{#644332} -- wpt-commits: c3f8e5c0bb15e7d7f57dbe60f6869caa0c4ad2e7 wpt-pr: 16084 UltraBlame original commit: f0294cf3eb4247c971f3860ff55bcdfd36029b05

…y/desynchronized/, a=testonly Automatic update from web-platform-tests WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ This CL renames s/lowLatency/desynchronized/ on web-exposed parts (s/low_latency/desynchronized/ internally) following [1,2] PRs (issue [3]), and extends wpt getContextAttributes.html. [1] whatwg/html#4360 [2] KhronosGroup/WebGL#2753 [3] whatwg/html#4087 Bug: 944199 Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 Reviewed-by: Philip Jägenstedt <foolipchromium.org> Commit-Queue: Miguel Casas <mcasaschromium.org> Cr-Commit-Position: refs/heads/master{#643323} -- wpt-commits: 02e61522099b874a0075d058f89b9f549563c6dc wpt-pr: 15982 UltraBlame original commit: d693cdd0e1c8d7eb678371f465099f1400d491db

…owLatency/desynchronized/", a=testonly Automatic update from web-platform-tests Revert "WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/" This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905. Reason for revert: Suspect cause of failure in webkit_layout_tests: * external/wpt/2dcontext/context-attributes/getContextAttributes.html https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391 Original change's description: > WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ > > This CL renames s/lowLatency/desynchronized/ on web-exposed parts > (s/low_latency/desynchronized/ internally) following [1,2] PRs > (issue [3]), and extends wpt getContextAttributes.html. > > [1] whatwg/html#4360 > [2] KhronosGroup/WebGL#2753 > [3] whatwg/html#4087 > > Bug: 944199 > Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 > Reviewed-by: Philip Jägenstedt <foolipchromium.org> > Commit-Queue: Miguel Casas <mcasaschromium.org> > Cr-Commit-Position: refs/heads/master{#643323} TBR=mcasaschromium.org,foolipchromium.org Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473 Reviewed-by: Fabrice de Gans-Riberi <fdeganschromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdeganschromium.org> Cr-Commit-Position: refs/heads/master{#643430} -- wpt-commits: d62bee5a53daade043c4704dc77379bdd2db0ea8 wpt-pr: 16029 UltraBlame original commit: 420ff79bebab20b467c3cd730cdebaf2b1ef97e7

…t, a=testonly Automatic update from web-platform-tests Extend canvas getContextAttributes WPTest This CL extend the WPTest for Canvas getContextAttributes to include the |desynchronized|. This CL covers the flag WPT test extension mentioned in whatwg/html#4360 (which addressed whatwg/html#4087). Bug: 944199, 945835 Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491 Reviewed-by: Fernando Serboncini <fserbchromium.org> Commit-Queue: Miguel Casas <mcasaschromium.org> Cr-Commit-Position: refs/heads/master{#644332} -- wpt-commits: c3f8e5c0bb15e7d7f57dbe60f6869caa0c4ad2e7 wpt-pr: 16084 UltraBlame original commit: 1c1904072b0147267351bba8d5eafee1ffad8d56