Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move where the user-valid/invalid flag is set. #10067

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Jan 16, 2024

Fixes #10066, matches at least WebKit and (soon) Gecko.

Also renames the flag to just "user valid or invalid flag", since that's what it is and it has nothing to do with user interaction.

(See WHATWG Working Mode: Changes for more details.)


/form-control-infrastructure.html ( diff )
/form-elements.html ( diff )
/input.html ( diff )
/interaction.html ( diff )
/semantics-other.html ( diff )

Since it has nothing to do with interaction.
Fixes whatwg#10066, matches WebKit and (soon) Gecko.
@emilio emilio requested review from annevk, nt1m and josepharhar January 16, 2024 11:28
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly editorial nits. I hope @nt1m and @josepharhar can review substance.

source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
@nt1m
Copy link
Member

nt1m commented Jan 16, 2024

Looks good to me.

@annevk annevk merged commit 055a678 into whatwg:main Feb 2, 2024
2 checks passed
@emilio emilio deleted the user-valid-invalid-fixes branch February 2, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

User interacted flag isn't always set on interactive submission
4 participants