From 6d2bd6bc2499cd3b81936298d8b85b1d2f14759e Mon Sep 17 00:00:00 2001 From: Mike West Date: Fri, 30 Sep 2016 14:18:02 +0200 Subject: [PATCH 1/2] Ensure that 'noopener' does not reuse a browsing context WIP: All of this would benefit from more substantial refactoring, but let's decide that this is the right way to approach things first. whatwg/html#1826 --- source | 96 ++++++++++++++++++++++++++++++++-------------------------- 1 file changed, 53 insertions(+), 43 deletions(-) diff --git a/source b/source index 2ee932b4039..f6141bc7e10 100644 --- a/source +++ b/source @@ -18558,8 +18558,8 @@ interface HTMLAnchorElement : HTMLElement { triggered by user activation; or, if the user has not indicated a specific browsing context for following the link, and the element's target attribute is present, and applying the rules - for choosing a browsing context given a browsing context name, using the value of the - target attribute as the browsing context name, would + for choosing a browsing context, using the value of the target attribute as the browsing context name, would result in there not being a chosen browsing context, then run these substeps:

    @@ -22142,20 +22142,27 @@ interface HTMLHyperlinkElementUtils { one permitted sandboxed navigator.

    Otherwise, if subject is an a or area element - that has a target attribute, then let target be the browsing context that is chosen by applying the - rules for choosing a browsing context given a browsing context name, using the value of - the target attribute as the browsing context name. If - these rules result in the creation of a new browsing context, set replace to true.

    + that has a target attribute, then let + target be the browsing context that is chosen by applying the + rules for choosing a browsing context, using the value of the target attribute as the browsing context name, and + a disown opener flag of true if the element has a rel + attribute whose value is "noopener" or "noreferrer", and false otherwise. If these rules result in the creation of a + new browsing context, set replace to true.

    Otherwise, if target is an a or area element with no target attribute, but the Document contains a base element with a target attribute, then let target be the browsing context that is chosen by applying the rules for choosing a browsing - context given a browsing context name, using the value of the target attribute of the first such base element as - the browsing context name. If these rules result in the creation of a new browsing - context, set replace to true.

    + context, using the value of the target attribute + of the first such base element as the browsing context name, and a disown opener + flag of true if the element has a rel + attribute whose value is "noopener" or "noreferrer", and false otherwise. If these rules result in the creation of a + new browsing context, set replace to true.

    +

    Otherwise, let target be source.

    @@ -37402,10 +37409,9 @@ interface HTMLAreaElement : HTMLElement { attribute and the algorithm is not triggered by user activation; or, if the user has not indicated a specific browsing context for following the link, and the element's target attribute is present, and applying - the rules for choosing a browsing context given a browsing context name, using the - value of the target attribute as the browsing - context name, would result in there not being a chosen browsing context, then run these - substeps:

    + the rules for choosing a browsing context, using the value of the target attribute as the browsing context name, would + result in there not being a chosen browsing context, then run these substeps:

      @@ -54677,10 +54683,10 @@ fur

    1. If the user indicated a specific browsing context to use when submitting the form, then let target browsing context be that browsing context. - Otherwise, apply the rules for choosing a browsing context given a browsing context - name using target as the name and form browsing - context as the context in which the algorithm is executed, and let target - browsing context be the resulting browsing context.

      2. + Otherwise, apply the rules for choosing a browsing context using target + as the name and form browsing context as the context in which the algorithm is + executed, and let target browsing context be the resulting browsing + context.

    2. If target browsing context was created in the previous step, or, alternatively, if the form document has not yet completely @@ -77877,15 +77883,16 @@ console.assert(iframeWindow.frameElement === null);

      Most of the restrictions on sandboxed browsing contexts are applied by other algorithms, e.g. the navigation algorithm, not the rules - for choosing a browsing context given a browsing context name given below.

      + for choosing a browsing context given below.

      -

      The rules for choosing a browsing context given a browsing context name are as - follows. The rules assume that they are being applied in the context of a browsing - context, as part of the execution of a task.

      +

      The rules for choosing a browsing context given a browsing context name and disown + opener flag are as follows. The rules assume that they are being applied in the context of a + browsing context, as part of the execution of a task.

        @@ -77911,10 +77918,10 @@ console.assert(iframeWindow.frameElement === null); browsing context whose name is the same as the given browsing context name, and the current browsing context is familiar with that browsing context, and the user agent determines that the two browsing contexts are related - enough that it is ok if they reach each other, then that browsing context must be the chosen - one. If there are multiple matching browsing contexts, the user agent should select one in some - arbitrary consistent manner, such as the most recently opened, most recently focused, or more - closely related.

        + enough that it is ok if they reach each other, and the disown opener flag is false, then that + browsing context must be the chosen one. If there are multiple matching browsing contexts, the + user agent should select one in some arbitrary consistent manner, such as the most recently + opened, most recently focused, or more closely related.

        @@ -77962,11 +77969,11 @@ console.assert(iframeWindow.frameElement === null); create a new browsing context:
        -

        A new auxiliary browsing context must be created, with the opener - browsing context being the current one. If the given browsing context name is not - _blank, then the new auxiliary browsing context's name must be the - given browsing context name (otherwise, it has no name). The chosen browsing context must be - this new browsing context.

        +

        A new top-level browsing context must be created. Its opener + browsing context is the current one if the disown opener flag is false, and empty + otherwise. If the given browsing context name is not _blank, then the + new browsing context's name must be the given browsing context name (otherwise, it has no + name). The chosen browsing context must be this new browsing context.

        If the newly created browsing context is immediately navigated, then the navigation will be done with replacement @@ -78647,6 +78654,10 @@ callback FrameRequestCallback = void (DOMHighResTimeStamp

        If target is the empty string, let it be the string "_blank" instead.

        +

      1. Let disown opener be true if the result of splitting features on commas contains the token "noopener" +

      2. If the user has indicated a preference for which browsing context to navigate, @@ -78670,18 +78681,18 @@ callback FrameRequestCallback = void (DOMHighResTimeStamp -

        Otherwise, apply the rules for choosing a browsing context given a browsing context - name using target as the name and source browsing context as the - context in which the algorithm is executed. If this results in there not being a chosen browsing - context, then return null. Otherwise, let target browsing context be the +

        Otherwise, apply the rules for choosing a browsing context using + target as the name, disown opener, and source browsing context + as the context in which the algorithm is executed. If this results in there not being a chosen + browsing context, then return null. Otherwise, let target browsing context be the browsing context so obtained.

      3. If target browsing context was just created, either as part of the rules - for choosing a browsing context given a browsing context name or due to the user - indicating a preference for navigating a new top-level browsing context, then let - new be true. Otherwise, let it be false.

        4. + for choosing a browsing context or due to the user indicating a preference for navigating + a new top-level browsing context, then let new be true. Otherwise, let it + be false.

      4. Interpret features as defined in the CSSOM View specification.

        5. @@ -78741,10 +78752,9 @@ callback FrameRequestCallback = void (DOMHighResTimeStamp -

      5. If the result of splitting features - on commas contains the token "noopener", then disown target browsing context's opener and - return null.

        6. +

      6. If disown opener is true, disown + target browsing context's opener, and return null.

      7. Otherwise, return the WindowProxy object of target browsing context.

        8. @@ -80216,7 +80226,7 @@ callback FrameRequestCallback = void (DOMHighResTimeStampEvery top-level browsing context has a popup sandboxing flag set, which is a sandboxing flag set. When a browsing context is created, its popup sandboxing flag set must be empty. It is populated by the rules for - choosing a browsing context given a browsing context name.

        + choosing a browsing context.

        Every browsing context that is a nested browsing context has an iframe sandboxing flag set, which is a sandboxing flag set. From bc7dff9dcde31bf48d2be41ed323cec4e2668f80 Mon Sep 17 00:00:00 2001 From: Mike West Date: Wed, 5 Oct 2016 10:30:35 +0200 Subject: [PATCH 2/2] fixup @bzbarsky --- source | 34 ++++++++++++++++++++-------------- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/source b/source index f6141bc7e10..01f5d3e80fd 100644 --- a/source +++ b/source @@ -18559,8 +18559,11 @@ interface HTMLAnchorElement : HTMLElement { browsing context for following the link, and the element's target attribute is present, and applying the rules for choosing a browsing context, using the value of the target attribute as the browsing context name, would - result in there not being a chosen browsing context, then run these substeps:

        + data-x="attr-hyperlink-target">target attribute as the browsing context name, and a + disown opener flag of true if the element has a rel + attribute whose value is "noopener" or "noreferrer", and false otherwise would result in there not being a chosen + browsing context, then run these substeps:

          @@ -37410,8 +37413,11 @@ interface HTMLAreaElement : HTMLElement { has not indicated a specific browsing context for following the link, and the element's target attribute is present, and applying the rules for choosing a browsing context, using the value of the target attribute as the browsing context name, would - result in there not being a chosen browsing context, then run these substeps:

          + data-x="attr-hyperlink-target">target attribute as the browsing context name, and a + disown opener flag of true if the element has a rel + attribute whose value is "noopener" or "noreferrer", and false otherwise would result in there not being a chosen + browsing context, then run these substeps:

            @@ -54684,9 +54690,9 @@ fur

          1. If the user indicated a specific browsing context to use when submitting the form, then let target browsing context be that browsing context. Otherwise, apply the rules for choosing a browsing context using target - as the name and form browsing context as the context in which the algorithm is - executed, and let target browsing context be the resulting browsing - context.

            2. + as the name, false as the disown opener flag, and form browsing context as the context + in which the algorithm is executed, and let target browsing context be the resulting + browsing context.

          2. If target browsing context was created in the previous step, or, alternatively, if the form document has not yet completely @@ -77969,11 +77975,12 @@ console.assert(iframeWindow.frameElement === null); create a new browsing context:

            -

            A new top-level browsing context must be created. Its opener - browsing context is the current one if the disown opener flag is false, and empty - otherwise. If the given browsing context name is not _blank, then the - new browsing context's name must be the given browsing context name (otherwise, it has no - name). The chosen browsing context must be this new browsing context.

            +

            A new top-level browsing context must be created. It will not have an + opener browsing context if the disown opener flag is true, otherwise its + opener browsing context is the current one. If the given browsing context name is + not _blank, then the new browsing context's name must be the given + browsing context name (otherwise, it has no name). The chosen browsing context must be this + new browsing context.

            If the newly created browsing context is immediately navigated, then the navigation will be done with replacement @@ -78752,8 +78759,7 @@ callback FrameRequestCallback = void (DOMHighResTimeStamp -

          3. If disown opener is true, disown - target browsing context's opener, and return

            If disown opener is true, and new is true, then return null.

          4. Otherwise, return the WindowProxy object of target browsing