From beb3aeaca8ab797316c6d28239b86ac699507c7f Mon Sep 17 00:00:00 2001 From: Dave Tapuska Date: Fri, 27 Mar 2020 16:21:12 -0400 Subject: [PATCH 1/2] Convert more "queue a task" to "queue an element task" This accounts for the links and input sections. Part of #4980. --- source | 46 ++++++++++++++++++++++++---------------------- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/source b/source index af1cfa45c51..4f03aaa4a28 100644 --- a/source +++ b/source @@ -23098,11 +23098,12 @@ document.body.appendChild(wbr);

  • If that is successful, let URL be the resulting URL string.

    -

    Otherwise, if parsing the URL failed, the - user agent may report the error to the user in a user-agent-specific manner, may queue a - task to navigate the target - browsing context to an error page to report the error, or may ignore the error and - do nothing. In any case, the user agent must then return.

    +

    Otherwise, if parsing the URL failed, the user + agent may report the error to the user in a user-agent-specific manner, may queue an + element task on the DOM manipulation task source given subject to + navigate the target browsing context + to an error page to report the error, or may ignore the error and do nothing. In any case, the + user agent must then return.

  • If there is a hyperlink suffix, append it to URL.

    • @@ -23117,15 +23118,13 @@ document.body.appendChild(wbr); request's referrer to "no-referrer".

    -

  • Queue a task to navigate the - target browsing context to request. If replace is - true, the navigation must be performed with replacement enabled. The - source browsing context must be source.

    • +

  • Queue an element task on the DOM manipulation task source given + subject to navigate the target + browsing context to request. If replace is true, the + navigation must be performed with replacement enabled. The source browsing + context must be source.

    • -

    The task source for the tasks mentioned above is the DOM manipulation task - source.

    - @@ -46909,14 +46908,15 @@ ldh-str = < as defined in mutable, the user agent should allow the user to change the files on the list in other ways also, e.g. adding or removing files by - drag-and-drop. When the user does so, the user agent must queue a task to first - update the element's selected files so that - it represents the user's new selection, then fire an - event named input at the input element, with - the bubbles attribute initialized to true, and finally - fire an event named change at the input element, with the bubbles attribute initialized to true.

    + drag-and-drop. When the user does so, the user agent must queue an element task on + the user interaction task source given the input element to first update + the element's selected files so that it + represents the user's new selection, then fire an event + named input at the input element, with the bubbles attribute initialized to true, and finally fire an event named change + at the input element, with the bubbles + attribute initialized to true.

    If the element is not mutable, the user agent must not allow the user to change the element's selection.

    @@ -47304,10 +47304,12 @@ ldh-str = < as defined in     task that is queued by the networking task source once the resource has been fetched, must, if the download was successful and the image is available, - queue a task to fire an event named queue an element task on the user interaction task source given the + input element to fire an event named load at the input element; and otherwise, if the fetching process fails without a response from the remote server, or completes but the image is not a valid - or supported image, queue a task to fire an + or supported image, queue an element task on the user interaction task + source given the input element to fire an event named error on the input element.

    From 06bdb125094457a75f07a8cd4795516636f53455 Mon Sep 17 00:00:00 2001 From: Dave Tapuska Date: Mon, 30 Mar 2020 14:18:57 -0400 Subject: [PATCH 2/2] Fix up a few more instances. --- source | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/source b/source index 4f03aaa4a28..1ca070db6ca 100644 --- a/source +++ b/source @@ -48899,10 +48899,12 @@ You cannot submit this form when the field is incorrect. to which these events apply, and for which the user interface involves both interactive manipulation and an explicit commit action, then when the user changes the element's value, the user agent must - queue a task to fire an event named queue an element task     on the user interaction task source given the + input element to fire an event named input at the input element, with the bubbles attribute initialized to true, and any time the user - commits the change, the user agent must queue a task to queue an element task on the user + interaction task source given the input element to fire an event named change at the input element, with the bubbles attribute initialized to true.

    @@ -48918,7 +48920,8 @@ You cannot submit this form when the field is incorrect. to which these events apply, and for which the user interface involves an explicit commit action but no intermediate manipulation, then any time the user commits a change to the element's value, the user - agent must queue a task to first fire an + agent must queue an element task on the user interaction task source + given the input element to first fire an event named input at the input element, with the bubbles attribute initialized to true, and then fire an event named change @@ -48940,11 +48943,12 @@ You cannot submit this form when the field is incorrect.

    For input elements without a defined input activation behavior, but to which these events apply, any time the user causes the element's value to change without an explicit commit - action, the user agent must queue a task to fire an + action, the user agent must queue an element task on the user interaction task + source given the input element to fire an event named input at the input element, with the bubbles attribute initialized to true. The - corresponding change event, if any, will be fired when - the control loses focus.

    + corresponding change event, if any, will be fired when the + control loses focus.

    Examples of a user changing the element's value would include the user typing into a text control, pasting @@ -48959,15 +48963,16 @@ You cannot submit this form when the field is incorrect. without a commit step.

    In the case of tasks that just fire an input event, user agents may wait for a suitable break in the - user's interaction before queuing the tasks; for example, a + data-x="event-input">input event, user agents may wait for a suitable break in the user's + interaction before queuing the tasks; for example, a user agent could wait for the user to have not hit a key for 100ms, so as to only fire the event when the user pauses, instead of continuously for each keystroke.

    When the user agent is to change an input element's value on behalf of the user (e.g. as part of a form prefilling - feature), the user agent must queue a task to first update the queue an element task on the user interaction + task source given the input element to first update the value accordingly, then fire an event named input at the input element, with the bubbles attribute initialized to true, then to the user manipulating the controls, without having to then filter out the script's own changes to avoid an infinite loop.)

    -

    The task source for these tasks is the - user interaction task source.

    -