Check for null before running 'fetch a modulepreload script graph' optional steps #5664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'fetch a modulepreload module script graph'.
|
I'm splitting this bugfix/clarification off from #5658 per @littledan 's suggestion. |
littledan
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently fetch a modulepreload module script graph optionally proceeds to steps to fetch the descendants of the preloaded module without checking the result of fetch a single module script for failure. It doesn't make sense to try to fetch descendants if the original fetch failed (e.g. due to 404), and fetch the descendants of and link doesn't expect to be passed a null
module script.Thus, this change guards the optional steps with a null check.
This clarification should be a no-op for implementers, who must already have this sort of check in place; there's not much that they could do otherwise.