Block import() in service workers #6395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
approved these changes
Feb 18, 2021
|
Tests: web-platform-tests/wpt#27699 |
|
Can you restore the pull request template? In particular links showing multi-implementer support would be useful, since apparently Firefox and Safari currently support |
|
Firefox is supportive, FWIW. cc @codehag |
Done, sorry about that.
I usually file those just-before-merging (in case there's any changes through discussion beforehand). |
domenic
approved these changes
Feb 22, 2021
jakearchibald
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 24, 2021
webkit-commit-queue
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Mar 14, 2021
https://bugs.webkit.org/show_bug.cgi?id=222308 Reviewed by Youenn Fablet. LayoutTests/imported/w3c: Covering service-worker case. * web-platform-tests/service-workers/service-worker/import-module-scripts.https-expected.txt: Source/WebCore: dynamic-import should be always rejected if script is executed in Worklets or ServiceWorkers. This is recently changed in the spec whatwg/html#6395. * bindings/js/ScriptModuleLoader.cpp: (WebCore::isWorkletOrServiceWorker): (WebCore::ScriptModuleLoader::importModule): LayoutTests: Covering worklet case. * http/wpt/webaudio/the-audio-api/the-audioworklet-interface/dynamic-import-is-prohibited.https-expected.txt: Added. * http/wpt/webaudio/the-audio-api/the-audioworklet-interface/dynamic-import-is-prohibited.https.html: Added. * http/wpt/webaudio/the-audio-api/the-audioworklet-interface/processors/dynamic-import-is-prohibited.js: Added. (DynamicImportIsProhibitedProcessor.prototype.process): (DynamicImportIsProhibitedProcessor): Canonical link: https://commits.webkit.org/235271@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@274404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
yury-s
pushed a commit
to yury-s/webkit-http
that referenced
this pull request
Mar 15, 2021
https://bugs.webkit.org/show_bug.cgi?id=222308 Reviewed by Youenn Fablet. LayoutTests/imported/w3c: Covering service-worker case. * web-platform-tests/service-workers/service-worker/import-module-scripts.https-expected.txt: Source/WebCore: dynamic-import should be always rejected if script is executed in Worklets or ServiceWorkers. This is recently changed in the spec whatwg/html#6395. * bindings/js/ScriptModuleLoader.cpp: (WebCore::isWorkletOrServiceWorker): (WebCore::ScriptModuleLoader::importModule): LayoutTests: Covering worklet case. * http/wpt/webaudio/the-audio-api/the-audioworklet-interface/dynamic-import-is-prohibited.https-expected.txt: Added. * http/wpt/webaudio/the-audio-api/the-audioworklet-interface/dynamic-import-is-prohibited.https.html: Added. * http/wpt/webaudio/the-audio-api/the-audioworklet-interface/processors/dynamic-import-is-prohibited.js: Added. (DynamicImportIsProhibitedProcessor.prototype.process): (DynamicImportIsProhibitedProcessor): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@274404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 15, 2021
…estonly Automatic update from web-platform-tests No dynamic import in service worker (#27699) Part of whatwg/html#6395 and w3c/ServiceWorker#1356 -- wpt-commits: a02460e35145989c6fe2365f03d1b0006f381d9d wpt-pr: 27699
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Mar 15, 2021
…estonly Automatic update from web-platform-tests No dynamic import in service worker (#27699) Part of whatwg/html#6395 and w3c/ServiceWorker#1356 -- wpt-commits: a02460e35145989c6fe2365f03d1b0006f381d9d wpt-pr: 27699 UltraBlame original commit: 4f89a146b69c4b14730d2418cbac4447c6ac461a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Mar 15, 2021
…estonly Automatic update from web-platform-tests No dynamic import in service worker (#27699) Part of whatwg/html#6395 and w3c/ServiceWorker#1356 -- wpt-commits: a02460e35145989c6fe2365f03d1b0006f381d9d wpt-pr: 27699 UltraBlame original commit: 4f89a146b69c4b14730d2418cbac4447c6ac461a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Mar 15, 2021
…estonly Automatic update from web-platform-tests No dynamic import in service worker (#27699) Part of whatwg/html#6395 and w3c/ServiceWorker#1356 -- wpt-commits: a02460e35145989c6fe2365f03d1b0006f381d9d wpt-pr: 27699 UltraBlame original commit: 4f89a146b69c4b14730d2418cbac4447c6ac461a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See WHATWG Working Mode: Changes for more details.)
Spec work for w3c/ServiceWorker#1356.
/webappapis.html ( diff )