Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Blocks #7009

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Module Blocks #7009

wants to merge 8 commits into from

Conversation

surma
Copy link
Contributor

@surma surma commented Sep 2, 2021

DO NOT MERGE YET

This PR adds the minimal integration of the TC39 Module Blocks proposal (spec) to the HTML spec. Specifically:

  • Adds support for Module Blocks to import()
  • Handles Module Blocks in the module map
  • Adds special cases for Module Blocks to StructuredSerializeInternal and StructuredDeserialize
  • It does not add support for Module Blocks to the Worker constructor, as we are still settling on a way forward here.

I got a bit caught off-guard by the changes to the module map with import assertions. I think I resolved the conflicts correctly, but please be extra thorough when looking at that part.

cc @littledan

Checklist:

  • At least two implementers are interested (and none opposed):
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chrome: …
    • Firefox: …
    • Safari: …

(See WHATWG Working Mode: Changes for more details.)


💥 Error: Wattsi server error 💥

PR Preview failed to build. (Last tried on Sep 2, 2021, 11:31 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.

🔗 Related URL

Parsing MDN data...
Parsing...
Parse Error: (92659,59) parse error while closing p element



If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant