Disallow interactive content in <summary>. #9372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the content model for <summary> to have the same restriction on interactive content that is present for the content model of <button>. This affects conformance for documents but not for user agents. Fixes whatwg#2272.
annevk
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
This looks fine to me.
Edit: I have some concerns: #2272 (comment).
Optional nit: align the wording with the <a> element (use "or" instead of "and no") both here and for <button> or vice versa.
@sideshowbarker should probably give this a once over as well, as Chief Validator^WChecker.
annevk
added
the
do not merge yet
|
I will not willingly implement this in the HTML checker, because I assess that on balance this restriction that the patch in this PR adds to the spec will end up wasting more time of HTML developer-authors than it helps others — or end up just being widely ignored. Longer comment at #2272 (comment) |
|
Based on the discussion in #2272, sounds like I should retract this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the content model for
<summary>to have the same restriction on interactive content that is present for the content model of<button>. This affects conformance for documents but not for user agents.Fixes #2272.
The rationale for this change is probably best described in #2272 (comment) by @scottaohara.
It looks to me like the bulk of the pull request template is not relevant here, since this change (while a normative change) affects only document conformance and not user agent conformance, and the template seems to focus on changes to user agent conformance. (It's possible we may also want to make some changes to user-agent conformance related to the handling of documents that this change would make nonconforming, but I think this change is probably the least controversial piece.) Let me know if you think I should fill out parts or all of the template, though.
/form-elements.html ( diff )
/interactive-elements.html ( diff )