Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

performance issue #27

Closed
tsukasagenesis opened this issue Oct 17, 2015 · 0 comments
Closed

performance issue #27

tsukasagenesis opened this issue Oct 17, 2015 · 0 comments

Comments

@tsukasagenesis
Copy link

Hello,

just performance issue, please change line 405 of parse :

if (ipaddr.IPv6.isValid(string)) {
to
if (string.indexOf(":") != -1 && ipaddr.IPv6.isValid(string)) {

because the valid test use too much performance, on dht tracker, I got 20% just on ipv6 check, after change get 20% performance improvement (on all software) !

regards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tsukasagenesis