-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ANIm should not be symmetric #373
Comments
Thanks @dparks1134 - apologies for the bug, and we'll deal with this as a priority. Quick notes
L. |
NOTE: Handling under branch |
Issue 373 - preliminary merge with multiple fixes to annoyances (warnings/small errors) prior to real fix of #373.
For reference, two sets of output for the genomes provided by @dparks1134, named |
I have pushed changes to I will see if there are other things I have missed; in particular, I think perhaps the test outputs might need to be updated; (they pass, but this might just mean the differences fall within the designated tolerances). |
I think your guess is probably correct. It would be useful to have (for the record) a |
I tried uploading the archive of inputs I used here, but I think that must be too big; I've instead included the Here's the output from running summary_run1_vs_run2.md Update Here are the updated versions of the summary report and plots; changes include—better colour maps, more useful axes, and more informative titles. (The run numbers differ because I always forget when you need to specify labels, et cetera.) |
It looks like Dickeya didantii NCPPB 898 chromosome, whole genome shotgun sequence specifically sees a lot of differences between the two. |
I'm also marking this for closure, because my understanding is that this issue was fixed with 1f10a6c. Specifically, we have now decided to run two pairwise comparisons (forward and reverse), and calculate ANIm values for query for each comparison. |
Summary:
PyANI treats ANIm as symmetric, but the order of genomes impacts this calculation.
Description:
I have two test genomes. The ANIm results produced by PyANI change depending on the order these genomes are processed. That is, the results depend on which genome is considered the "reference" and which the "query" when running nucmer.
Reproducible Steps:
average_nucleotide_identity.py -m ANIm --workers 1
.As a concrete results, the number of similarity errors changes from 512 to 561 depending on the order of the genomes.
Expected Output:
test_genomes.tar.gz
The ANI-percentage_identity.tab, ANIm_similarity_errors.tab, and ANIm_alignment_lengths.tab files are non-symmetric matrices that reflect which genome was the reference and which genome was the query.
pyani Version:
v0.2.11
Operating System:
Ubuntu
The text was updated successfully, but these errors were encountered: