Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_version() tests based on discussion surrounding Issue #405 #410

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

baileythegreen
Copy link
Contributor

Makes changes to the get_version() tests discussed in Issue #405 in the other subcommand APIs.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update
  • This is a documentation update

Action Checklist

  • Work on a single issue/concept (if there are multiple separate issues to address, please use a separate pull request for each)
  • Fork the pyani repository under your own account (please allow write access for repository maintainers)
  • Set up an appropriate development environment (please see CONTRIBUTING.md)
  • Create a new branch with a short, descriptive name
  • Work on this branch
    • style guidelines have been followed
    • new code is commented, especially in hard-to-understand areas
    • corresponding changes to documentation have been made
    • tests for the change have been added that demonstrate the fix or feature works
  • Test locally with pytest -v non-passing code will not be merged
  • Rebase against origin/master
  • Check changes with flake8 and black before submission
  • Commit branch
  • Submit pull request, describing the content and intent of the pull request
  • Request a code review
  • Continue the discussion at Pull requests section in the pyani repository

@baileythegreen baileythegreen added the tests issues relating to tests label Jul 29, 2022
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #410 (2b0702d) into master (62949c4) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
+ Coverage   75.82%   75.92%   +0.10%     
==========================================
  Files          55       55              
  Lines        3747     3763      +16     
==========================================
+ Hits         2841     2857      +16     
  Misses        906      906              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests issues relating to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant