From caf33a154fcd0ae00525ef65bf419cbc872cf809 Mon Sep 17 00:00:00 2001 From: Toni Sevener Date: Wed, 29 Jan 2025 09:13:40 -0600 Subject: [PATCH 1/3] Update CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 51917aaecac..2ae832dab99 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -15,7 +15,7 @@ If you're ready to pick up more difficult work, look at the iOS backlog and pick Now you want to let the team know what you're working on. 1. In Phabricator, assign the task to yourself. -2. Add the release tag "iOS Release FY2023-24" to the task. [This link](https://phabricator.wikimedia.org/project/board/7291/) will take you to our current release board. Tagging your task with the name of the release will add it to the release board. +2. Add the release tag "iOS Release FY2024-25" to the task. [This link](https://phabricator.wikimedia.org/project/board/7291/) will take you to our current release board. Tagging your task with the name of the release will add it to the release board. 3. On the release board, move the task to the "Doing" column. 4. When you're done developing, move the task to the "Needs Code Review" column. From 380579d210bd372633c6121fb8120c6ce91f100d Mon Sep 17 00:00:00 2001 From: Toni Sevener Date: Wed, 29 Jan 2025 09:29:44 -0600 Subject: [PATCH 2/3] Update tag name --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2ae832dab99..855fdc1867f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -7,7 +7,7 @@ Before developing, please read the [setup instructions](README.md). Once your contributions are ready for review, add yourself in alphabetical order under contributors in `Code/AboutViewController.plist` and post a pull request on GitHub. One of the maintainers will review the PR. Thanks for contributing! 🎉 ## What can I work on? -If you're looking for easy work, look at the tasks marked with the "good first bug" tag. [This link](https://phabricator.wikimedia.org/project/board/782/query/7vYTqNgpvqjh/) will show you all the "good first bug" tasks in the iOS backlog. +If you're looking for easy work, look at the tasks marked with the "good first task" tag. [This link](https://phabricator.wikimedia.org/project/board/782/query/7vYTqNgpvqjh/) will show you all the "good first task" tasks in the iOS backlog. If you're ready to pick up more difficult work, look at the iOS backlog and pick something from the Bug Backlog column. [This link](https://phabricator.wikimedia.org/project/board/782/) will show you all the tasks in the iOS backlog. If the status of the task is unclear or you need more information, feel free to leave a comment and we'll try to respond as soon as possible. From d87d98ead17961ebb6f7f5f37ebee70f5156938d Mon Sep 17 00:00:00 2001 From: Toni Sevener Date: Wed, 29 Jan 2025 09:59:22 -0600 Subject: [PATCH 3/3] Link to MediaWiki contribution page, delete duplicate contribute documentation. --- CONTRIBUTING.md | 35 ----------------------------------- README.md | 2 +- 2 files changed, 1 insertion(+), 36 deletions(-) delete mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md deleted file mode 100644 index 855fdc1867f..00000000000 --- a/CONTRIBUTING.md +++ /dev/null @@ -1,35 +0,0 @@ -# Contributing -We welcome volunteers to contribute to the Wikipedia iOS app codebase. - -## Development instructions -Before developing, please read the [setup instructions](README.md). - -Once your contributions are ready for review, add yourself in alphabetical order under contributors in `Code/AboutViewController.plist` and post a pull request on GitHub. One of the maintainers will review the PR. Thanks for contributing! 🎉 - -## What can I work on? -If you're looking for easy work, look at the tasks marked with the "good first task" tag. [This link](https://phabricator.wikimedia.org/project/board/782/query/7vYTqNgpvqjh/) will show you all the "good first task" tasks in the iOS backlog. - -If you're ready to pick up more difficult work, look at the iOS backlog and pick something from the Bug Backlog column. [This link](https://phabricator.wikimedia.org/project/board/782/) will show you all the tasks in the iOS backlog. If the status of the task is unclear or you need more information, feel free to leave a comment and we'll try to respond as soon as possible. - -## I found my task. What next? -Now you want to let the team know what you're working on. - -1. In Phabricator, assign the task to yourself. -2. Add the release tag "iOS Release FY2024-25" to the task. [This link](https://phabricator.wikimedia.org/project/board/7291/) will take you to our current release board. Tagging your task with the name of the release will add it to the release board. -3. On the release board, move the task to the "Doing" column. -4. When you're done developing, move the task to the "Needs Code Review" column. - -## GitHub is not running unit tests on my pull request -This is a known limitation with Xcode Cloud (see more details in [T358110](https://phabricator.wikimedia.org/T358110)). We will still review your PR, and a maintainer will confirm run tests locally before merging. Details on improvements we're planning can be found in [T362932](https://phabricator.wikimedia.org/T362932). - -## I don't want to work on my task any more. -You can let us know by unassigning the task and moving it back to the "Tasks from Product Backlog" column. - -## How will I know that my contribution was accepted? -Your PR will be merged and your task will get moved to the "Ready for PM Signoff" column. This means that your contribution will be included in the upcoming release. - -## Tips -[Wiki on how to use Phabricator](https://www.mediawiki.org/wiki/Phabricator/Project_management) - - - diff --git a/README.md b/README.md index 17df8d24b0c..3d5066f9244 100644 --- a/README.md +++ b/README.md @@ -26,7 +26,7 @@ If you'd rather install the development prerequisites yourself without our scrip * [**ClangFormat**](https://clang.llvm.org/docs/ClangFormat.html) - We use this for linting Objective-C code. ## Contributing -Covered in the [contributing document](CONTRIBUTING.md). +Covered in our [contributing documention](https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/iOS#Contribute_to_development) on MediaWiki. ## Development Guidelines These are general guidelines rather than hard rules.