[WFLY-18943] Fix automated testing of OpenTelemetry QS under OpenShift #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasondlee
force-pushed
the
WFLY-18943
branch
3 times, most recently
from
353d6f5
to
5a5f6df
Compare
Build with openshift profile Clean up YAML Modify how WF is configured under OS build Add instructions for deploying otel collector on OS
emmartins
reviewed
Jan 30, 2024
| @@ -2,5 +2,11 @@ build: | |||
| uri: https://github.com/wildfly/quickstart.git | |||
| ref: main | |||
| contextDir: opentelemetry-tracing | |||
| env: | |||
There was a problem hiding this comment.
Not needed, the openshift profile is used by default.
| @@ -0,0 +1,16 @@ | |||
| === Install OpenTelemetry Collector on OpenShift | |||
|
|
|||
| The functionality of this quickstart depends on a running instance of the https://opentelemetry.io/docs/collector/[OpenTelemetry Collector]. To deploy and configure the OpenTelemetry Collector, you will need to apply a set of configurations to your OpenShift cluster. In your terminal, run the following command to configure the OpenTelemetry Collector as well as any external routes needed: | |||
There was a problem hiding this comment.
IMHO we should not ask them to run the huge command first, here is my suggestion:
The functionality of this quickstart depends on a running instance of the https://opentelemetry.io/docs/collector/[OpenTelemetry Collector].
To deploy and configure the OpenTelemetry Collector, you will need to apply a set of configurations to your OpenShift cluster, to configure the OpenTelemetry Collector as well as any external routes needed:
[source,options="nowrap",subs="+attributes"]
----
include::charts/opentelemetry-collector.yaml[]
----
To make things simpler, you can find these commands in `charts/opentelemetry-collector.yaml`, and to apply them run the following command in your terminal:
[source]
----
$ oc apply -f charts/opentelemetry-collector.yaml
----
| <scripts> | ||
| <script>${basedir}/configure-opentelemetry.cli</script> | ||
| </scripts> | ||
| <commands> |
There was a problem hiding this comment.
IMHO it is preferable to use the cli script, since that is used also for baremetal config. I did some tests with Openshift Local and a modified branch of and the following worked fine:
<packaging-scripts>
<packaging-script>
<scripts>
<script>${basedir}/configure-opentelemetry.cli</script>
</scripts>
<resolve-expressions>false</resolve-expressions>
</packaging-script>
</packaging-scripts>
| @@ -220,6 +230,9 @@ | |||
| <layer>jaxrs-server</layer> | |||
| <layer>opentelemetry</layer> | |||
| </layers> | |||
| <plugin-options> | |||
There was a problem hiding this comment.
dupe, please remove this change
|
This PR has been superseded by #872 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFLY-18943
Build with openshift profile
Clean up YAML
Modify how WF is configured under OS build
Fix application deployment in POM file