-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several improvements to get and modify. #115
Open
glebius
wants to merge
11
commits into
williamh:master
Choose a base branch
from
glebius:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to quote as many most recent bug comments in your reply as you need.
glebius
force-pushed
the
master
branch
3 times, most recently
from
December 27, 2023 21:04
3eddb2c
to
3dd9b03
Compare
glebius
changed the title
Add a functionality to quote recent comments in your replies within interactive editor. Fixes a bug before that.
Several improvements to get and modify.
Dec 27, 2023
Use default '%+ UTC' as Bugzilla WebUI does. Provide key/config option to override that.
Keep track of real names as we parse the bug and reuse the dictionary as we print list of comments. Should work unless somebody has commented and then unsubscribed from Cc, in that case fallback to just email.
With this change and preceding real name and date/time changes a comment header gets as close to the WebUI as possible.
Not a useful header and makes it closer to WebUI.
in a chronological order, just like WebUI does. Try our best with pretty-printing bug changes and fall back to printing the hash in the worst case.
Also, make these two extensions automatically raise the patch flag. Also, make the patch flag set content type to text/plain, unless mimetypes was able to say something. P.S. Python's mimetypes module is really helpless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This boils down to the following changes: