Pre-release cleanup and fixes #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In tests the QPA plugin is never destroyed. We need to clean up all remaining screens as this is not guaranteed by the wlroots backend.
The name of The Compositor Modules should be capitalized.
It is more an example of how to use The Compositor Modules, not a test.
As an exmaple it is sufficient to run it from the build directory.
This was only in the .gitlab-ci.yml file.
We have ported most of the pipeline to GitHub Actions. Since it's unused here on GitHub anyway let's remove it.
The manual tests go into a separate subdirectory.
The function is not used and we can remove the last test still using Qt Test.
Unit tests are now in a separate unit directory.
It's the standard naming scheme in most projects and it cleans up the toplevel directory some more.
They are not in use at the moment and outdated.
This is really relevant only for the KDE Plasma desktop. It's therefore a better suited place. This might need to be revisited though when we have a more generic configuration API.
Most files already respected the style.
Minico doesn't use scripting and input is already included by the base platform header.
This is then using the same pattern like for the other platform objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly improvements to repo structure and docs.