Completed npm commands (npm:install, npm:update, npm:run)

[jaxwilko]

This PR removes [vite|mix]:installs ability to install an npm package into the root package.json (a hold over from the previous mix system). In it's place it adds the commands npm:install <compileablePackage?> <npmPackage> which allows the user to install a packge into a workspace.

I.e. if I want to add leftpad to my plugin JaxWilko.Example I can run ./artisan npm:install jaxwilko.example leftpad which will then add the dependency to plugins/jaxwilko/example/package.json then run the install command as the root project owner (root package). This is powered by npm and we just need to run the right command in the workspace package.

This PR also reworks npm:update and npm:run so they share a parent with the npm execution logic and simplifies their internal logic.

NPM Run

npm:run still works as before. ./artisan npm:run jaxwilko.example test will execute the test script within the jaxwilko.example package.

NPM Update

npm:update now supports a package to update, as well as now taking a assetPackage to specify which workspace to run the command within.

• ./artisan npm:update jaxwilko.example tailwindcss will update tailwindcss within jaxwilko.example
• ./artisan npm:update tailwindcss will update tailwindcss globally (within the root package, workspaces can still install their own independent version).

NPM Install

• ./artisan npm:install jaxwilko.example tailwindcss will install tailwindcss within jaxwilko.example
• ./artisan npm:install tailwindcss will install tailwindcss in the root package.json
• ./artisan npm:install tailwindcss --dev will install tailwindcss within devDependencies rather than dependencies

TODO

• New tests
  • npm:install
  • npm:update
  • npm:run
• Fix detection of ignored packages in asset:install
• Fix detection of missing configuration and offer to run config creation command in asset:install
• Restict asset:install to only install requested package and not all unless no package is specified

[josephcrowell]

Yes that's the expected behavior.

[josephcrowell]

In the mean time, until this is merged, what would be the correct npm command to do the equivalent npm update on a plugin or theme?

I was working on a puppeteer based html to pdf plugin specific to winter and capable of using Firefox that I would like to continue development on and a Daisy UI based theme.

[bennothommo]

@josephcrowell yes, you can use npm directly if you wish. I would be using it on the project root as opposed to within the plugin or theme itself, in order to completely replicate what the artisan command does.

[LukeTowers]

@jaxwilko are there any changes that could be made to the docs?

[jaxwilko]

@LukeTowers probably yes, at least some work on clarification of the expected / actual behaviour, i'll open a PR tomorrow and also add some more comments to the code in this PR to make it more clear what's going on :)

[jaxwilko]

Docs update PR: wintercms/docs#213

[LukeTowers]

@jaxwilko what's left?

[jaxwilko]

@LukeTowers just reworking the exceptions

[jaxwilko]

@LukeTowers custom exceptions have been removed and replaced with SystemException