Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set min iOS version to iOS 12 #1

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Conversation

billypchan
Copy link

@billypchan billypchan commented Sep 2, 2021

Goals ⚽

When archiving with Carthage (macOS 11, Xcode 13.0 beta 5), error is produced for:
error: 'NWConnection' is only available in iOS 12.0 or newer
I would like fix the error simple fulfil this by drop iOS 12- support which we already done in all frameworks.

Implementation Details 🚧

Change min iOS version from 9 to 12

@typfel
Copy link
Member

typfel commented Sep 2, 2021

Why do we need enforce the iOS 12 as the deployment target for third party frameworks? Shouldn't it be fine for frameworks to support earlier iOS versions and we then only need to enforce the deployment target at the top level in Wire-iOS app?

@billypchan
Copy link
Author

@typfel I update the comment. This issue occurs when archiving with Xcode 13 with xcodebuild.

@typfel
Copy link
Member

typfel commented Sep 2, 2021

@typfel I update the comment. This issue occurs when archiving with Xcode 13 with xcodebuild.

OK so this is a workaround for what appears to be some misconfiguration/bug in Starscream and not something we need to do for all third party frameworks.

@billypchan billypchan merged commit 09b4d81 into master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants