-
Notifications
You must be signed in to change notification settings - Fork 296
chore: Use beta version of web-packages on dev [WPB-21306] #19811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates all @wireapp/ packages from stable to beta versions for testing on the dev environment as part of WPB-21306. The beta versions follow a consistent naming pattern with commit hash references (e.g., 5.4.10-beta.54.5ce5ca523), enabling testing of pre-release features before production deployment.
Key changes:
- Updated 11 direct
@wireapp/dependencies to beta versions with commit hash identifiers - Updated ESLint configuration introduces modern tooling (eslint-plugin-jest v29, eslint-plugin-react-hooks v5, etc.)
- New transitive dependencies added for improved module resolution and WASM/NAPI runtime support
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated 11 @wireapp packages to beta versions in both dependencies and devDependencies sections |
| yarn.lock | Lockfile update reflecting package.json changes, plus transitive dependency additions from @wireapp/eslint-config update (unrs-resolver with platform bindings, @emnapi packages, and updated ESLint plugins) |
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
Failed Tests:❌ Account Management (tags: TC-8639, crit-flow-web)Location: specs/CriticalFlow/accountManagement-TC-8639.spec.ts:37 Errors: ❌ Team owner adds whole team to an all team chat (tags: TC-8631, crit-flow-web)Location: specs/CriticalFlow/addMembersToChat-TC-8631.spec.ts:43 Errors: ❌ Planning group call with sending various messages during call (tags: TC-8632, crit-flow-web)Location: specs/CriticalFlow/groupCalls-TC-8632.spec.ts:37 Errors: ❌ Group Video call (tags: TC-8637, crit-flow-web)Location: specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:39 Errors: ❌ New person joins team and setups up device (tags: TC-8635, crit-flow-web)Location: specs/CriticalFlow/joinTeam-TC-8635.spec.ts:38 Errors: Flaky Tests: |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| 'react-hooks/rules-of-hooks': 'off', | ||
| 'react-hooks/exhaustive-deps': 'off', |
Copilot
AI
Nov 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new @wireapp/eslint-config@3.1.8-beta.54.5ce5ca523 upgrades eslint-plugin-react-hooks from v4 to v5. Disabling these rules specifically for test files may be hiding issues that should be addressed. Consider:
- Investigate why tests are failing with the stricter react-hooks rules in v5
- Fix the test code to comply with the rules rather than disabling them
- If disabling is truly necessary, document why with a comment explaining the rationale
These rules help prevent common React bugs:
rules-of-hooksensures hooks are only called at the top levelexhaustive-depsprevents stale closures and missing dependencies
| 'react-hooks/rules-of-hooks': 'off', | |
| 'react-hooks/exhaustive-deps': 'off', | |
| // If you need to disable react-hooks rules for tests, document the rationale here. | |
| // 'react-hooks/rules-of-hooks': 'off', | |
| // 'react-hooks/exhaustive-deps': 'off', |
| "@wireapp/react-ui-kit": "9.69.7-beta.11.d0ceefa60", | ||
| "@wireapp/store-engine-dexie": "2.1.21-beta.54.5ce5ca523", | ||
| "@wireapp/telemetry": "0.3.7-beta.51.d0ceefa60", | ||
| "@wireapp/webapp-events": "0.28.6-beta.51.d0ceefa60", |
Copilot
AI
Nov 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The beta versions use three different commit hashes (5ce5ca523, d0ceefa60, a0e2528f5), which suggests these packages were built from different commits. This creates an inconsistent dependency state that could lead to:
- Unexpected integration issues between packages built at different times
- Difficulty reproducing and debugging issues
- Unclear which version of the codebase is actually deployed
Consider coordinating the beta releases to use a single commit hash across all @wireapp packages, or document why different commits are necessary for this migration.
| "@wireapp/react-ui-kit": "9.69.7-beta.11.d0ceefa60", | |
| "@wireapp/store-engine-dexie": "2.1.21-beta.54.5ce5ca523", | |
| "@wireapp/telemetry": "0.3.7-beta.51.d0ceefa60", | |
| "@wireapp/webapp-events": "0.28.6-beta.51.d0ceefa60", | |
| "@wireapp/react-ui-kit": "9.69.7-beta.11.5ce5ca523", | |
| "@wireapp/store-engine-dexie": "2.1.21-beta.54.5ce5ca523", | |
| "@wireapp/telemetry": "0.3.7-beta.51.5ce5ca523", | |
| "@wireapp/webapp-events": "0.28.6-beta.51.5ce5ca523", |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #19811 +/- ##
=======================================
Coverage 43.46% 43.46%
=======================================
Files 1296 1296
Lines 32570 32570
Branches 7232 7232
=======================================
Hits 14157 14157
Misses 16698 16698
Partials 1715 1715 🚀 New features to boost your workflow:
|



Pull Request
Summary
Migrated all of web-packages to use the beta version as part of WPB-21306
none
Security Checklist (required)
Standards Acknowledgement (required)