feat(cloudflare): add astro assets image service #34

alexanderniebuhr · 2023-10-20T21:57:15Z

Changes

refactor of automatic noop behavior
added support for external paid Cloudflare Image Resizing Service
Added a new option flag which will also help with fix(cloudflare): allow compile-time image optimization for prerendered pages #53
package updates & test suite renames, which shouldn't be in here but which I needed to solve some very strange issue with mocha

Testing

added a new test based on the astro:assets test, however I still wish to test just the output of updateConfig if that is somehow possible

Docs

changesets
readme

changeset-bot · 2023-10-20T21:57:18Z

🦋 Changeset detected

Latest commit: 4587fea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages

Name	Type
@astrojs/cloudflare	Minor
@test/astro-cloudflare-dev-runtime	Patch
@test/astro-cloudflare-directory-mode	Patch
@test/astro-cloudflare-external-image-service	Patch
@test/astro-cloudflare-function-per-route	Patch
@test/astro-cloudflare-hybrid	Patch
@test/astro-cloudflare-no-output	Patch
@test/astro-cloudflare-prerender	Patch
@test/astro-cloudflare-routes-json	Patch
@test/astro-cloudflare-wasm-function-per-route	Patch
@test/astro-cloudflare-wasm-directory	Patch
@test/astro-cloudflare-wasm	Patch
@test/astro-cloudflare-with-solid-js	Patch
@test/astro-cloudflare-wrangler-runtime	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

alexanderniebuhr · 2023-10-20T21:57:26Z

main
- feat(cloudflare): add astro assets image service #34 👈
  - feat(cloudflare): support "compile-time" only image config for astro:assets #58

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexanderniebuhr and the rest of your teammates on Graphite

alexanderniebuhr · 2023-10-21T17:37:57Z

!preview cf-assets

alexanderniebuhr · 2023-10-21T17:41:34Z

!preview cf-assets

alexanderniebuhr · 2023-10-21T17:56:11Z

!preview cf-assets

alexanderniebuhr · 2023-10-21T18:08:00Z

!preview cf-assets

alexanderniebuhr · 2023-10-21T19:30:56Z

!preview cf-assets

github-actions · 2023-10-21T19:31:48Z

Snapshots have been released for the following packages:

@astrojs/cloudflare@experimental--cf-assets

Publish Log

🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the experimental--cf-assets tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info @astrojs/cloudflare
🦋  info npm info @astrojs/netlify
🦋  info @astrojs/cloudflare is being published because our local version (0.0.0-cf-assets-20231021193132) has not been published on npm
🦋  warn @astrojs/netlify is not being published because version 3.0.3 is already published on npm
🦋  info Publishing "@astrojs/cloudflare" at "0.0.0-cf-assets-20231021193132"
🦋  success packages published successfully:
🦋  @astrojs/cloudflare@0.0.0-cf-assets-20231021193132
🦋  Creating git tag...
🦋  New tag:  @astrojs/cloudflare@0.0.0-cf-assets-20231021193132

Build Log


> root@0.0.0 build /home/runner/work/adapters/adapters
> turbo run build --filter="@astrojs/*"

• Packages in scope: @astrojs/cloudflare, @astrojs/netlify, @astrojs/test-utils
• Running build in 3 packages
• Remote caching disabled
::group::@astrojs/netlify:build
cache miss, executing 523429d520638068

> @astrojs/netlify@3.0.3 build /home/runner/work/adapters/adapters/packages/netlify
> tsc

::endgroup::
::group::@astrojs/cloudflare:build
cache miss, executing d5cfcf8e1352385c

> @astrojs/cloudflare@0.0.0-cf-assets-20231021193132 build /home/runner/work/adapters/adapters/packages/cloudflare
> tsc

::endgroup::

 Tasks:    2 successful, 2 total
Cached:    0 cached, 2 total
  Time:    5.222s

packages/cloudflare/src/entrypoints/image-service.ts

alexanderniebuhr · 2023-11-05T21:06:16Z

!preview cf-assets

github-actions · 2023-11-05T21:07:28Z

Snapshots have been released for the following packages:

@astrojs/cloudflare@experimental--cf-assets
@astrojs/netlify@experimental--cf-assets

Publish Log

🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the experimental--cf-assets tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info @astrojs/cloudflare
🦋  info npm info @astrojs/netlify
🦋  info @astrojs/cloudflare is being published because our local version (0.0.0-cf-assets-20231105210708) has not been published on npm
🦋  info @astrojs/netlify is being published because our local version (0.0.0-cf-assets-20231105210708) has not been published on npm
🦋  info Publishing "@astrojs/cloudflare" at "0.0.0-cf-assets-20231105210708"
🦋  info Publishing "@astrojs/netlify" at "0.0.0-cf-assets-20231105210708"
🦋  success packages published successfully:
🦋  @astrojs/cloudflare@0.0.0-cf-assets-20231105210708
🦋  @astrojs/netlify@0.0.0-cf-assets-20231105210708
🦋  Creating git tags...
🦋  New tag:  @astrojs/cloudflare@0.0.0-cf-assets-20231105210708
🦋  New tag:  @astrojs/netlify@0.0.0-cf-assets-20231105210708

Build Log


> root@0.0.0 build /home/runner/work/adapters/adapters
> turbo run build --filter="@astrojs/*"

• Packages in scope: @astrojs/cloudflare, @astrojs/netlify, @astrojs/test-utils
• Running build in 3 packages
• Remote caching disabled
::group::@astrojs/netlify:build
cache miss, executing c8857cd3314ec362

> @astrojs/netlify@0.0.0-cf-assets-20231105210708 build /home/runner/work/adapters/adapters/packages/netlify
> tsc

::endgroup::
::group::@astrojs/cloudflare:build
cache miss, executing bb9edaf37626e064

> @astrojs/cloudflare@0.0.0-cf-assets-20231105210708 build /home/runner/work/adapters/adapters/packages/cloudflare
> tsc

::endgroup::

 Tasks:    2 successful, 2 total
Cached:    0 cached, 2 total
  Time:    5.143s

alexanderniebuhr · 2023-11-06T12:36:29Z

!preview cf-assets

packages/cloudflare/src/utils/assets.ts

alexanderniebuhr · 2023-11-08T07:31:21Z

.changeset/shaggy-wasps-care.md

+'@astrojs/cloudflare': minor
+---
+
+Adds support for external Cloudflare Image Resizing Service. See Cloudflare docs for more information about Pricing and Features: https://developers.cloudflare.com/images/image-resizing/


Should we also link to the announcement post, that their pricing will change starting Nov 15?

https://blog.cloudflare.com/merging-images-and-image-resizing/

cc @withastro/maintainers-docs

.changeset/grumpy-adults-retire.md

packages/cloudflare/README.md

packages/cloudflare/src/utils/image-config.ts

packages/cloudflare/test/fixtures/dev-runtime/astro.config.mjs

packages/cloudflare/test/fixtures/external-image-service/astro.config.mjs

packages/cloudflare/src/entrypoints/image-service.ts

packages/cloudflare/src/utils/image-config.ts

dreyfus92

Hey @alexanderniebuhr, awesome job 🚀. I left you a couple of minor suggestions. Let me know what are your thoughts.

.changeset/dull-candles-perform.md

.changeset/shaggy-wasps-care.md

packages/cloudflare/README.md

sarah11918

Just made a few tiny suggestions for you to consider, @alexanderniebuhr !

packages/cloudflare/README.md

.changeset/dull-candles-perform.md

.changeset/shaggy-wasps-care.md

Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com> Co-authored-by: Arsh <69170106+lilnasy@users.noreply.github.com> Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>

github-actions bot added the pkg: cloudflare label Oct 20, 2023

alexanderniebuhr marked this pull request as ready for review October 21, 2023 05:14

alexanderniebuhr force-pushed the nbhr/add_external_image_service_for_cloudflare branch from f665ea0 to 8d15c14 Compare October 21, 2023 05:16

alexanderniebuhr marked this pull request as draft October 21, 2023 05:17

withastro deleted a comment from github-actions bot Oct 21, 2023

alexanderniebuhr marked this pull request as ready for review October 21, 2023 17:41

alexanderniebuhr force-pushed the nbhr/add_external_image_service_for_cloudflare branch 2 times, most recently from 77f890f to 3059602 Compare October 21, 2023 18:07

github-actions bot added the docs pr label Oct 21, 2023

alexanderniebuhr marked this pull request as draft October 21, 2023 18:08

alexanderniebuhr mentioned this pull request Oct 21, 2023

fix: snapshot release main branch not found withastro/astro#8885

Merged

alexanderniebuhr force-pushed the nbhr/add_external_image_service_for_cloudflare branch 3 times, most recently from a81f69c to 11d0a64 Compare November 2, 2023 18:08

alexanderniebuhr commented Nov 5, 2023

View reviewed changes

packages/cloudflare/src/entrypoints/image-service.ts Show resolved Hide resolved

alexanderniebuhr force-pushed the nbhr/add_external_image_service_for_cloudflare branch from 11d0a64 to 56c68ac Compare November 5, 2023 21:04

alexanderniebuhr force-pushed the nbhr/add_external_image_service_for_cloudflare branch 3 times, most recently from 0b3b034 to 80693ff Compare November 6, 2023 12:35

alexanderniebuhr force-pushed the nbhr/add_external_image_service_for_cloudflare branch from a191609 to 5e720c4 Compare November 8, 2023 06:56

alexanderniebuhr commented Nov 8, 2023

View reviewed changes

packages/cloudflare/src/utils/assets.ts Outdated Show resolved Hide resolved

alexanderniebuhr force-pushed the nbhr/add_external_image_service_for_cloudflare branch 3 times, most recently from f9ffebc to 6d1fd90 Compare November 8, 2023 07:29

alexanderniebuhr marked this pull request as ready for review November 8, 2023 07:29

alexanderniebuhr commented Nov 8, 2023

View reviewed changes

alexanderniebuhr force-pushed the nbhr/add_external_image_service_for_cloudflare branch from 6d1fd90 to 749bb92 Compare November 8, 2023 07:55

alexanderniebuhr requested a review from Princesseuh November 8, 2023 08:01

alexanderniebuhr force-pushed the nbhr/add_external_image_service_for_cloudflare branch from 749bb92 to 9ec6728 Compare November 8, 2023 08:02

matthewp approved these changes Nov 8, 2023

View reviewed changes