From d23967a7f464eb7190ea7edc331adb131dd8eaac Mon Sep 17 00:00:00 2001 From: lilnasy <69170106+lilnasy@users.noreply.github.com> Date: Wed, 1 Nov 2023 19:37:23 +0000 Subject: [PATCH] enabled without configuration --- .changeset/tricky-clocks-end.md | 15 +++---------- packages/integrations/vercel/README.md | 22 ------------------- .../vercel/src/serverless/adapter.ts | 10 +-------- .../test/fixtures/streaming/astro.config.mjs | 4 +--- 4 files changed, 5 insertions(+), 46 deletions(-) diff --git a/.changeset/tricky-clocks-end.md b/.changeset/tricky-clocks-end.md index cf89895ec748..acd314b1fdbd 100644 --- a/.changeset/tricky-clocks-end.md +++ b/.changeset/tricky-clocks-end.md @@ -1,16 +1,7 @@ --- -'@astrojs/vercel': minor +'@astrojs/vercel': major --- -The Vercel adapter now allows you to enable streaming! +The Vercel adapter now streams responses! -Bring better performance to your visitors by showing them content as it is rendered. The browser can also start loading the required stylesheets and scripts much sooner, which ultimately results in faster full page loads. - - -```diff -export default defineConfig({ - output: "server", - adapter: vercel({ -+ streaming: true - }), -}); +This brings better performance to your visitors by showing them content as it is rendered. The browser can also start loading the required stylesheets and scripts much sooner, which ultimately results in faster full page loads. diff --git a/packages/integrations/vercel/README.md b/packages/integrations/vercel/README.md index f30f7b4f8ae5..bad219b98c89 100644 --- a/packages/integrations/vercel/README.md +++ b/packages/integrations/vercel/README.md @@ -281,28 +281,6 @@ export default defineConfig({ }); ``` -### streaming - -**Type:** `boolean`
-**Available for:** Serverless - -Determines whether or not the serverless function will stream its response to the browser, sending components as they are rendered. - -The default value is `false`. Set this value to `true` in your Vercel adapter configuration to enable streaming. - -```diff lang="js" -// astro.config.mjs -import { defineConfig } from 'astro/config'; -import vercel from '@astrojs/vercel/serverless'; - -export default defineConfig({ - output: "server", - adapter: vercel({ -+ streaming: true - }), -}); -``` - ### Function bundling configuration The Vercel adapter combines all of your routes into a single function by default. diff --git a/packages/integrations/vercel/src/serverless/adapter.ts b/packages/integrations/vercel/src/serverless/adapter.ts index 759de5533365..621849688ff3 100644 --- a/packages/integrations/vercel/src/serverless/adapter.ts +++ b/packages/integrations/vercel/src/serverless/adapter.ts @@ -105,9 +105,6 @@ export interface VercelServerlessConfig { /** The maximum duration (in seconds) that Serverless Functions can run before timing out. See the [Vercel documentation](https://vercel.com/docs/functions/serverless-functions/runtimes#maxduration) for the default and maximum limit for your account plan. */ maxDuration?: number; - - /** Whether to allow the serverless function to stream the response to the browser. */ - streaming?: boolean; } export default function vercelServerless({ @@ -122,7 +119,6 @@ export default function vercelServerless({ functionPerRoute = false, edgeMiddleware = false, maxDuration, - streaming, }: VercelServerlessConfig = {}): AstroIntegration { if (maxDuration) { if (typeof maxDuration !== 'number') { @@ -280,7 +276,6 @@ You can set functionPerRoute: false to prevent surpassing the limit.` includeFiles: filesToInclude, excludeFiles, maxDuration, - streaming, }); routeDefinitions.push({ src: route.pattern.source, @@ -297,7 +292,6 @@ You can set functionPerRoute: false to prevent surpassing the limit.` includeFiles: filesToInclude, excludeFiles, maxDuration, - streaming, }); routeDefinitions.push({ src: '/.*', dest: 'render' }); } @@ -348,7 +342,6 @@ interface CreateFunctionFolderArgs { includeFiles: URL[]; excludeFiles?: string[]; maxDuration: number | undefined; - streaming: boolean | undefined; } async function createFunctionFolder({ @@ -360,7 +353,6 @@ async function createFunctionFolder({ includeFiles, excludeFiles, maxDuration, - streaming, }: CreateFunctionFolderArgs) { const functionFolder = new URL(`./functions/${functionName}.func/`, config.outDir); @@ -389,7 +381,7 @@ async function createFunctionFolder({ handler, launcherType: 'Nodejs', maxDuration, - supportsResponseStreaming: streaming, + supportsResponseStreaming: true, }); } diff --git a/packages/integrations/vercel/test/fixtures/streaming/astro.config.mjs b/packages/integrations/vercel/test/fixtures/streaming/astro.config.mjs index b8d6f3034bcc..b1a48b07df94 100644 --- a/packages/integrations/vercel/test/fixtures/streaming/astro.config.mjs +++ b/packages/integrations/vercel/test/fixtures/streaming/astro.config.mjs @@ -3,7 +3,5 @@ import vercel from '@astrojs/vercel/serverless'; export default defineConfig({ output: "server", - adapter: vercel({ - streaming: true - }) + adapter: vercel() });