Allow dynamic route segments in @astrojs/vercel isr.exclude array

[tk04]

Astro Info

Astro                    v4.5.6
Node                     v20.11.0
System                   macOS (arm64)
Package Manager          npm
Output                   server
Adapter                  @astrojs/vercel/serverless
Integrations             none

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

When using the @astrojs/vercel integration, I want to exclude a dynamic route from using ISR. Currently, there seems to be no way to do this. All the routes that are passed into the isr.exclude array are matched exactly as is.

astro/packages/integrations/vercel/src/serverless/adapter.ts

Lines 354 to 357 in ad57a02

	for (const route of isrConfig.exclude) {
	// vercel interprets src as a regex pattern, so we need to escape it
	routeDefinitions.push({ src: escapeRegex(route), dest });
	}

What's the expected result?

The processing of the isr.exclude array should offer a way to match dynamic route segments. Therefore, when the code is built, the route src values in the.vercel/output/config.json file should reflect dynamic route segments accordantly.

The strings are currently processed like this:

astro/packages/integrations/vercel/src/lib/redirects.ts

Lines 79 to 81 in ad57a02

	export function escapeRegex(content: string) {
	return `^${getMatchPattern([[{ content, dynamic: false, spread: false }]])}$`;
	}

It would be nice to enable dynamic values using /:path or /[path]. A solution might look something like this:

function escapeRegex(content) {
  return `^${getMatchPattern(
    content.split("/").map((value) => [
      {
        content: value,
        dynamic: value.startsWith(":"),
        spread: false,
      },
    ]),
  )}$`;
}

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-alhqnq?file=astro.config.mjs

Participation

• I am willing to submit a pull request for this issue.

[ematipico]

This sounds more like a feature request, not a bug report.

As far as I remember, ISR accepts regex too.

[tk04]

The route src values in the config.json file allow regex, but the exclude.isr array doesn't, the values are always escaped:

astro/packages/integrations/vercel/src/serverless/adapter.ts

Lines 354 to 357 in ad57a02

	for (const route of isrConfig.exclude) {
	// vercel interprets src as a regex pattern, so we need to escape it
	routeDefinitions.push({ src: escapeRegex(route), dest });
	}

[lilnasy]

The exclude field currently only accepts verbatim paths, but I think it makes sense for it to handle dynamic and spread segments like /[path].

It would work similarly to how configured redirects are processed. We have utilities somewhere that turn /api/[path] into the regular expression /api/([^/]+?).

[lilnasy]

This would be a new feature.

[lilnasy]

Implemented in #10513. Thanks @tk04!