Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bun no longer being detected in astro/cli/install-package.ts #10748

Closed
1 task
jacobdalamb opened this issue Apr 10, 2024 · 6 comments
Closed
1 task

Bun no longer being detected in astro/cli/install-package.ts #10748

jacobdalamb opened this issue Apr 10, 2024 · 6 comments
Labels
- P2: nice to have Not breaking anything but nice to have (priority)

Comments

@jacobdalamb
Copy link
Contributor

jacobdalamb commented Apr 10, 2024

Astro Info

Astro                    v4.5.18
Node                     v20.11.0
System                   macOS (arm64)
Package Manager          bun
Output                   server
Adapter                  @astrojs/vercel/serverless
Integrations             none

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

Running bun astro check returns
CleanShot 2024-04-10 at 13 22 41

What's the expected result?

Should say bun add @astrojs/check typescript

Link to Minimal Reproducible Example

https://astro.new/basics?on=stackblitz

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Apr 10, 2024
@lilnasy
Copy link
Contributor

lilnasy commented Apr 10, 2024

Bun is not a supported package manager. If it works, it works, but it will be a conversation before we make an official decision to add it.

@jacobdalamb
Copy link
Contributor Author

Bun is not a supported package manager. If it works, it works, but it will be a conversation before we make an official decision to add it.

No, but it should be properly detecting it. https://github.com/withastro/astro/blob/main/packages/astro/src/cli/install-package.ts

@jacobdalamb jacobdalamb changed the title Astro check doesn't respect Bun Bun no longer being detected in install-package.ts Apr 10, 2024
@lilnasy
Copy link
Contributor

lilnasy commented Apr 10, 2024

Is there something about your environment that could be preventing detection of bun?

@jacobdalamb
Copy link
Contributor Author

Is there something about your environment that could be preventing detection of bun?

I don't think so. I tried running it on a new astro project and I got the same result.

@lilnasy lilnasy added - P2: nice to have Not breaking anything but nice to have (priority) and removed needs triage Issue needs to be triaged labels Apr 10, 2024
@lilnasy
Copy link
Contributor

lilnasy commented Apr 10, 2024

I notice that you added bun detection in #8306. Did it stop working after a certain version?

@jacobdalamb
Copy link
Contributor Author

I notice that you added bun detection in #8306. Did it stop working after a certain version?

I guess it must have stopped working, or I didn't check a scenario when running a cli command for an integration that isn't installed. Because bun detection works for creating a new astro project, astro info, and adding integrations.

I'm not sure if this issue takes place in index.ts or install-package.ts

@jacobdalamb jacobdalamb changed the title Bun no longer being detected in install-package.ts Bun no longer being detected in astro/cli/install-package.ts Apr 14, 2024
@jacobdalamb jacobdalamb closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P2: nice to have Not breaking anything but nice to have (priority)
Projects
None yet
Development

No branches or pull requests

2 participants