Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): pass search params to fallback #12547

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

mtwilliams-code
Copy link
Contributor

Changes

Testing

Tested locally with the same code in the stackblitz example in issue. Ran all i18n test suites. Did not add a specific test for this - if maintainers want I will, but wanted feedback on willingness to include this before I dove into the fixtures.

Docs

/cc @withastro/maintainers-docs for feedback!
May need docs. The current behavior is also undocumented and imo less intuitive.

Copy link

changeset-bot bot commented Nov 28, 2024

🦋 Changeset detected

Latest commit: 3e42275

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release labels Nov 28, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #12547 will not alter performance

Comparing mtwilliams-code:fix-i18n-search (3e42275) with main (176fe9f)

Summary

✅ 6 untouched benchmarks

@ascorbic
Copy link
Contributor

This looks good. Could you add a test for this? Probably in packages/astro/test/i18n-routing.test.js

@mtwilliams-code
Copy link
Contributor Author

Screenshot 2024-12-02 at 10 49 44 AM added test which fails without this fix and is now resolved for fallback, as well as one that ensures search is received by render when rewrite/reroute doesnt occur

@mtwilliams-code
Copy link
Contributor Author

@ematipico this seems to be your baby - any concerns?

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixes look good, we need to address the changeset, it's not a minor (this is a blocker)

I also, I suggested few changes in the tests.

.changeset/kind-mayflies-argue.md Outdated Show resolved Hide resolved
packages/astro/test/i18n-routing.test.js Outdated Show resolved Hide resolved
.changeset/kind-mayflies-argue.md Outdated Show resolved Hide resolved
@ematipico ematipico merged commit 6b6e18d into withastro:main Dec 5, 2024
16 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants