fix(assets): Propagate sizes attribute on all sources #8986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cbdacfc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ematipico
approved these changes
Nov 2, 2023
|
Changeset missing |
Merged
natemoo-re
pushed a commit
that referenced
this pull request
Nov 22, 2023
* fix(assets): Propagate `sizes` attribute on all sources * refactor: small refactor exposed srcSet types * test: update test with a sizes * chore: changeset * fix: use a type import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
sizesattribute needs to be on everysourceelement, much like it is on theimgone. We were wrongly not including it.This PR also includes a small refactor to the types of the internal
srcSetobject we pass around, we had two types with the same name when really, only one is needed.Testing
Edited the picture test to test for
sizesas well, since you can't really usewidthswithout it anyway.Docs
N/A