Fix DEV mode on Safari when view transitioning to client:only components #9000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e3d3345 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
bluwy
approved these changes
Nov 6, 2023
sarah11918
reviewed
Nov 6, 2023
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
ematipico
approved these changes
Nov 6, 2023
lilnasy
approved these changes
Nov 6, 2023
|
@lilnasy thanks for the hint about Webkit under Windows ;-) Otherwise I wouldn't have had a chance! |
Merged
natemoo-re
pushed a commit
that referenced
this pull request
Nov 22, 2023
…nts (#9000) * Fix DEV mode on Safari when view transitioning to client:only components * Update .changeset/eighty-ladybugs-shake.md Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> --------- Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #8988
Currently, "iframe.srcdoc" is not equally well supported by all browsers. At least I have not yet found a way that works with the import resolution of Safari. However, it works well with Firefox and Chrome. With great regret I have changed
srcdocback tosrc.Details
Falling back to
srcis not my favorite approach: the reason for usingsrcdocwas that we can render the possibly modified in-memory version of newDocument, not the file provided by the server.The reason srcdoc doesn't work on webkit browsers is that srcdoc changes the
documentURItoabout:srcdoc, which leads to errors when resolving absolute URLs with no origin. (All browsers setabout:srcdocin this way, but the others seem to have special cased the resolution)I've tried to fix this by rewriting URLs starting with
"/"to"http://...", using the actuallocation.originfrom the main document or setting<base>for theiframe.contentDocument, but I've had no success so far.If anyone knows a way to use
srcdocacross browsers without errors, I would be happy to hear about it :)We could POST the HTML of the newDocument to the DEV server and GET it back for the
srcattribute.Testing
Tested manually with Webkit on Windows.
Docs
n/a, bug fix
Always happy about better .changeset wording