Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use jpeg source files as fallback rather than converting to png #9010

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Use jpeg source files as fallback rather than converting to png #9010

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
624be4d
Use jpeg source files as fallback rather than converting to png
jasikpark Nov 6, 2023
36c91e9
Update comment for `specialFormatsFallback
jasikpark Nov 6, 2023
26e7364
Add a changeset file
jasikpark Nov 6, 2023
dbdb7aa
Update .changeset/quiet-games-film.md
jasikpark Nov 6, 2023
ad65351
Update .changeset/quiet-games-film.md
Princesseuh Nov 8, 2023
fbcc04d
Merge branch 'main' into add-jpeg-as-a-picture-fallback
Princesseuh Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-games-film.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"astro": minor
---

`<Picture />`: Use jpeg source files as their own fallback rather than using png as the fallback
Princesseuh marked this conversation as resolved.
Show resolved Hide resolved
3 changes: 2 additions & 1 deletion packages/astro/components/Picture.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ const defaultFallbackFormat = 'png' as const;
// Certain formats don't want PNG fallbacks:
// - GIF will typically want to stay as a gif, either for animation or for the lower amount of colors
// - SVGs can't be converted to raster formats in most cases
// - JPEGs compress photographs and high-noise images better than PNG in most cases
// For those, we'll use the original format as the fallback instead.
const specialFormatsFallback = ['gif', 'svg'] as const;
const specialFormatsFallback = ['gif', 'svg', 'jpg', 'jpeg'] as const;

const { formats = defaultFormats, pictureAttributes = {}, fallbackFormat, ...props } = Astro.props;

Expand Down
Loading