fix(middleware): do not import user middleware if not preset #9057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 625c54f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
force-pushed
the
fix/integration-middleware-api
branch
from
041a7ae to
cdfb7c4
Compare
github-actions
bot
added
pkg: astro
ematipico
force-pushed
the
fix/integration-middleware-api
branch
from
cdfb7c4 to
625c54f
Compare
matthewp
approved these changes
Nov 10, 2023
Merged
|
@ematipico Not sure how this was any different from the original iteration. Line 47 is untouched as well. |
natemoo-re
pushed a commit
that referenced
this pull request
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #9047
We need to track if the user doesn't have a middleware. If not, we should not attempt to import it.
Testing
I created a new fixture with not user middleware but with integration middlewares.
Docs
N/A