Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue where ReadableStream wasn't canceled in dev mode #9971

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Fix an issue where ReadableStream wasn't canceled in dev mode #9971

merged 3 commits into from
Feb 13, 2024

Conversation

mingjunlu
Copy link
Contributor

@mingjunlu mingjunlu commented Feb 4, 2024 •
edited
Loading

Changes

Testing

Docs

  • N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: bc1c161

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 4, 2024
lilnasy
lilnasy approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@lilnasy lilnasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks for the clean fix!

@ematipico ematipico merged commit d9266c4 into withastro:main Feb 13, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Feb 13, 2024
Merged
@mingjunlu mingjunlu deleted the fix/cancel-readable-stream-in-dev-mode branch February 13, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoustaphaDev MoustaphaDev MoustaphaDev approved these changes

@lilnasy lilnasy lilnasy approved these changes

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReadableStream in response body not canceled when client closes connection (in dev mode)
4 participants
@mingjunlu @ematipico @lilnasy @MoustaphaDev