Skip to content

Conversation

@DevVali
Copy link
Contributor

@DevVali DevVali commented Nov 20, 2025

No description provided.

@netlify
Copy link

netlify bot commented Nov 20, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2bf1177
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/6920628313e31c0008f25fda
😎 Deploy Preview https://deploy-preview-12748--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Nov 20, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/deploy/cloudflare.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@DevVali
Copy link
Contributor Author

DevVali commented Nov 20, 2025

It might happen that this removal is needed in other parts of the sample config code as well, I've only used the static setup though so can't say for the other ones.

Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DevVali for taking the time to fix our docs. It would have been helpful if you had uses our PR template and added a description to let us know why this is needed. Fortunately, Oliver opened a similar PR with a bit more context: #12754

I left a suggestion because I don't think removing this line is the right solution here.

@ArmandPhilippot ArmandPhilippot added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) code snippet update Updates a code sample: typo, outdated code etc. labels Nov 21, 2025
Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone, and sorry for the previous confusion. 😅 Everything seems correct to me, and this sounds ready to be merged!

@ArmandPhilippot ArmandPhilippot merged commit 48ce21f into withastro:main Nov 21, 2025
10 checks passed
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Nov 24, 2025
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code snippet update Updates a code sample: typo, outdated code etc. improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants