-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: remove binding assets #12748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove binding assets #12748
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
It might happen that this removal is needed in other parts of the sample config code as well, I've only used the static setup though so can't say for the other ones. |
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DevVali for taking the time to fix our docs. It would have been helpful if you had uses our PR template and added a description to let us know why this is needed. Fortunately, Oliver opened a similar PR with a bit more context: #12754
I left a suggestion because I don't think removing this line is the right solution here.
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks everyone, and sorry for the previous confusion. 😅 Everything seems correct to me, and this sounds ready to be merged!
No description provided.